Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Increase indenting to please Python-markdown #1935

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

MikeSpreitzer
Copy link
Contributor

@MikeSpreitzer MikeSpreitzer commented Mar 20, 2024

Summary

This PR increases the indenting of lines in numbered list items, because Python-markdown requires at least 4 spaces in order to recognize the nesting.

Related issue(s)

Fixes #1928

Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2024
@MikeSpreitzer
Copy link
Contributor Author

/cc @pdettori
/cc @clubanderson
/cc @ezrasilvera

@ezrasilvera
Copy link
Contributor

@MikeSpreitzer Not related to the PR - but why do we need this description in a separate file? This should be a section in "setting up KIND environment" or something

Copy link
Contributor

@pdettori pdettori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine at least in the GitHub markdown view
/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 262f881eea78594b8f37dc518292e3761d964649

@MikeSpreitzer
Copy link
Contributor Author

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MikeSpreitzer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@kcp-ci-bot kcp-ci-bot merged commit 8a5decc into kubestellar:main Mar 20, 2024
12 of 13 checks passed
@MikeSpreitzer MikeSpreitzer deleted the indent4 branch March 20, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug: step numbers are messed up on website
4 participants