Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Unify the README files on kubestellar.io and on kubestellar github #1961

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

ezrasilvera
Copy link
Contributor

  1. Unify the README files on kubestellar.io and on kubestellar github
  2. Update contributors

Summary

Related issue(s)

Fixes #

Signed-off-by: Ezra Silvera <ezra@il.ibm.com>
Signed-off-by: Ezra Silvera <ezra@il.ibm.com>
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 26, 2024
Copy link
Contributor

@pdettori pdettori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0601dec262c161caf58ffe0aae307dfb5c4e30b3

@ezrasilvera
Copy link
Contributor Author

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ezrasilvera

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@kcp-ci-bot kcp-ci-bot merged commit be81199 into kubestellar:main Mar 26, 2024
12 checks passed

**NOTE**: Our documentation generally appears on the website [kubestellar.io](https://kubestellar.io), although release 0.20.0 is not documented there and release 0.21.0 is only slightly documented there. For releases 0.20.0 and later, the documentation is also made to be viewed directly on GitHub's view of the source documents; find them [there](docs/content/direct). Release `X.Y.Z` is the commit with Git tag `vX.Y.Z`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this line deleted? I thought it is still true. Retreating from docs being viewable directly through GitHub is a major policy change, not something that two people should do without consulting anyone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants