✨ e2e tests for the latest release #1967
Conversation
kcp-ci-bot
added
dco-signoff: yes
effi-ofer
added
the
do-not-merge/hold
|
|
||
| - name: show workstatuses | ||
| if: always() | ||
| run: kubectl --context imbs1 get workstatuses -A -o yaml |
There was a problem hiding this comment.
I see less red in GitHub when there is a terminal linebreak.
There was a problem hiding this comment.
You mean that red symbol that resembles a do not enter sign? Adding a terminal linebreak avoids that symbol in github?
There was a problem hiding this comment.
added a blank line.
|
Note to @MikeSpreitzer - I am not sure how to go about testing this? I would like to try the implementation of the action workflow in this PR as well as a variant of it that uses the following trigger: |
effi-ofer
removed
the
do-not-merge/hold
Tested locally on my fork by merging into main and then creating a release named 'release-mike'. |
| paths-ignore: | ||
| - 'docs/**' | ||
| - '**/*.md' |
There was a problem hiding this comment.
I suspect that this may cause us problems by suppressing activation for a commit that only changes docs. It is not uncommon for the last commit in a release to be one that only changes docs (e.g., fixing self-reference(s)).
There was a problem hiding this comment.
You're right. And my bad for letting this one slip in.
|
|
||
| - name: Run test | ||
| env: | ||
| TEST_FLAGS: ${{ github.event.inputs.testFlags }} |
There was a problem hiding this comment.
This is broken and unused stuff copied from some other workflow, right?
There was a problem hiding this comment.
You mean the TEST_FLAGS right? I removed them now.
|
|
||
| - name: Run test | ||
| env: | ||
| TEST_FLAGS: ${{ github.event.inputs.testFlags }} |
effi-ofer
force-pushed
the
release-test
branch
2 times, most recently
from
46f37be
to
40cffd5
Compare
Signed-off-by: Effi Ofer <effi.ofer@gmail.com>
|
LGTM label has been added. Git tree hash: 35f4b99d8b01b724cdb2e67674049a150393d0e9
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MikeSpreitzer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Summary
Add e2e tests for the latest release.
Related issue(s)
Fixes #1590