Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix more broken links #1989

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

MikeSpreitzer
Copy link
Contributor

Discovered intended way to publish docs/README.md.

Summary

This PR replaces one relative link to non-doc contents and recognizes the intended way to publish docs/README.md.

Related issue(s)

Fixes #

Discovered intended way to publish docs/README.md.

Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2024
@MikeSpreitzer
Copy link
Contributor Author

/cc @clubanderson
@ezrasilvera

@@ -47,7 +47,7 @@ The KubeStellar and its leadership embrace the following values:

KubeStellar Maintainers have write access to the [project GitHub repository](https://github.com/kubestellar/kubestellar).
They can merge their own patches or patches from others. The current maintainers
can be found as top-level approvers in [OWNERS](./OWNERS). Maintainers collectively
can be found as top-level approvers in [OWNERS](https://github.com/kubestellar/kubestellar/blob/main/OWNERS). Maintainers collectively
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note this remove the dependency on version. Even if the files is always there, all versions will point to the latest OWNERS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is intentional. I think that for this file, it is always the current version that is relevant.

@ezrasilvera
Copy link
Contributor

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a0233f6c06881dcf5ecdb4fe2d421743645619c0

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ezrasilvera

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2024
@kcp-ci-bot kcp-ci-bot merged commit 930fdcd into kubestellar:main Mar 30, 2024
12 checks passed
@MikeSpreitzer MikeSpreitzer deleted the fixlinx2 branch March 31, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants