-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Updates for the controller manager to watch everything #2000
Conversation
pkg/binding/controller.go
Outdated
@@ -455,7 +455,7 @@ func (c *Controller) handleObject(obj any, resource string, eventType string) { | |||
obj = typed.Obj | |||
wasDeletedFinalStateUnknown = true | |||
} | |||
c.logger.Info("Got object event", "eventType", eventType, | |||
c.logger.V(3).Info("Got object event", "eventType", eventType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make these V levels even higher. At least 4, maybe 5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to 4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 1b7ea9e682c97e45e4370ee75a65e683b24ea4fb
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ezrasilvera The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
This PR increases the memory limit of the controller manager, and adjusts the verbosity levels for the logging messages from the event handlers.
Changes in this PR are built into quay.io/junatibm/controller-manager:1711835357. I tested the image, with the increased memory limit, in the same environment as #1990. The controller ran for minutes without
OOMKilled
:Also trying to hit #2000 by this PR.
Related issue(s)
Fixes #1990