Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate addon for elastic cloud #287

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

generate addon for elastic cloud #287

wants to merge 7 commits into from

Conversation

AveryQi115
Copy link
Contributor

Signed-off-by: Nicola115 2225992901@qq.com

Description of your changes

generate addon for elastic cloud

How has this code been tested?

vela addon enable ./addons/terraform-ec EC_API_KEY=xx

image

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] or [Trait]).
  • Updated/Added any relevant [documentation] and [examples].
  • Unit/E2E Tests added.

@zzxwill
Copy link
Collaborator

zzxwill commented Mar 15, 2022

@AveryQi115 AveryQi115 mentioned this pull request Mar 16, 2022
Merged
4 tasks
@AveryQi115
Copy link
Contributor Author

add resource to further verify the addon.
image

image

zzxwill
zzxwill previously approved these changes Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@zzxwill zzxwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Please also updated docs for kubevela.io.

@AveryQi115
generate addon for elastic cloud
e3a4d07 
Signed-off-by: Nicola115 <2225992901@qq.com>
@AveryQi115
rename provider ec as elastic
694a031 
Signed-off-by: Nicola115 <2225992901@qq.com>
@AveryQi115
add component definitions to further verify provider elastic
53ff374 
Signed-off-by: Nicola115 <2225992901@qq.com>
@AveryQi115
remove empty doc
f47f532 
Signed-off-by: Nicola115 <2225992901@qq.com>
@AveryQi115
restore metadata.yaml
37a6875 
Signed-off-by: Nicola115 <2225992901@qq.com>
@AveryQi115
restore metadata.yaml
8adea5b 
Signed-off-by: Nicola115 <2225992901@qq.com>
zzxwill
zzxwill previously approved these changes Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@zzxwill zzxwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@AveryQi115
remove shortCloudName and completeCloudName in the terraform-elastic/…
5a32f6b 
…metadata

Signed-off-by: Nicola115 <2225992901@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzxwill zzxwill zzxwill left review comments

@wangyikewxgm wangyikewxgm wangyikewxgm left review comments

@wonderflow wonderflow Awaiting requested review from wonderflow wonderflow is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AveryQi115 @zzxwill @wangyikewxgm