Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Addon] Replace Dex logo with KubeVela logo #342

Merged
merged 1 commit into from
May 6, 2022
Merged

[Addon] Replace Dex logo with KubeVela logo #342

merged 1 commit into from
May 6, 2022

Conversation

charlie0129
Copy link
Member

@charlie0129 charlie0129 commented May 5, 2022 •
edited
Loading

Signed-off-by: Charlie Chiang charlie_c_0129@outlook.com

Description of your changes

  • Replaces Dex logo with KubeVela logo (when using Dex addon), with light and dark variants.
  • No direct editing to the source code of Dex, which could result in incompatibility later on.

Screen Shot 2022-05-06 at 2 57 48 AM

Fixes #3583 (kubevela)

How has this code been tested?

Manually tested (see the screenshot above).

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] or [Trait]).
  • Updated/Added any relevant [documentation] and [examples].
  • Unit/E2E Tests added.

@charlie0129
Feat: replace Dex logo with KubeVela logo
15cba75 
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
barnettZQG
barnettZQG approved these changes May 6, 2022
View reviewed changes
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wonderflow
wonderflow approved these changes May 6, 2022
View reviewed changes
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job

@wonderflow wonderflow merged commit 4b46deb into kubevela:master May 6, 2022
@charlie0129 charlie0129 mentioned this pull request Jul 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonderflow wonderflow wonderflow approved these changes

@barnettZQG barnettZQG barnettZQG approved these changes

@wangyikewxgm wangyikewxgm Awaiting requested review from wangyikewxgm wangyikewxgm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Replace Dex logo with KubeVela logo
3 participants
@charlie0129 @wonderflow @barnettZQG