Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon] Add ChartMuseum addon #396

Merged
merged 5 commits into from
Jul 4, 2022
Merged

Conversation

charlie0129
Copy link
Member

@charlie0129 charlie0129 commented Jun 30, 2022

Description of your changes

Add ChartMuseum addon, with some sane default values for new users.

Parameters

Screenshot from 2022-07-01 19-20-22

Closes kubevela/kubevela#4138

How has this code been tested?

This addon has been installed and used as vela addon registries.

Screenshot from 2022-07-01 00-06-52
Screenshot from 2022-07-01 00-19-20
Screenshot from 2022-07-01 00-08-14

Checklist

I have:

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
@charlie0129 charlie0129 marked this pull request as draft June 30, 2022 19:00
@charlie0129 charlie0129 marked this pull request as ready for review July 1, 2022 09:48
@wangyikewxgm
Copy link
Collaborator

wangyikewxgm commented Jul 1, 2022

Good job! Since this addon is a critical component building private addon registry,can we put this to verified addon directly?

@charlie0129
Copy link
Member Author

Sure, if that's better. I will move this out of experimental addons.

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
@wonderflow
Copy link
Collaborator

kubevela/kubevela#4138

Copy link
Collaborator

@wangyikewxgm wangyikewxgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Create chart-museum addon
3 participants