Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Experimental] add clickhouse addon #404

Merged
merged 5 commits into from
Jul 29, 2022
Merged

[Experimental] add clickhouse addon #404

merged 5 commits into from
Jul 29, 2022

Conversation

wonderflow
Copy link
Collaborator

Signed-off-by: Jianbo Sun jianbo.sjb@alibaba-inc.com

Description of your changes

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.
  • Any changes about verified addons should be tested with CI script.

@wonderflow wonderflow marked this pull request as draft July 8, 2022 13:58
@wonderflow wonderflow changed the title wip add clickhouse addon [Experimental] add clickhouse addon Jul 11, 2022
@wonderflow wonderflow force-pushed the clickhouse branch 2 times, most recently from 1a38d26 to d5dc797 Compare July 26, 2022 07:37
@wonderflow
wip add clickhouse addon
fefdbd1 
Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
@wonderflow
add clickhouse addon
392025e 
Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
@wonderflow
use auto detect
90a7830 
Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
@wonderflow
Add clickhouse addon
d41ef43 
Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
@wonderflow wonderflow marked this pull request as ready for review July 29, 2022 03:55
@wonderflow
update readme for clickhouse
e7d43b3 
Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
wangyikewxgm
wangyikewxgm approved these changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@wangyikewxgm wangyikewxgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangyikewxgm wangyikewxgm merged commit b06d9c8 into kubevela:master Jul 29, 2022
@wonderflow wonderflow deleted the clickhouse branch July 29, 2022 05:03
MimicTester1307 pushed a commit to MimicTester1307/catalog that referenced this pull request Aug 10, 2022
@wonderflow @MimicTester1307
[Experimental] add clickhouse addon (kubevela#404)
7a51545 
* wip add clickhouse addon

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>

* add clickhouse addon

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>

* use auto detect

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>

* Add clickhouse addon

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>

* update readme for clickhouse

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangyikewxgm wangyikewxgm wangyikewxgm approved these changes

@barnettZQG barnettZQG Awaiting requested review from barnettZQG barnettZQG is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wonderflow @wangyikewxgm