Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Addon] metrics addons #418

Merged
merged 2 commits into from
Jul 27, 2022
Merged

[Addon] metrics addons #418

merged 2 commits into from
Jul 27, 2022

Conversation

Somefive
Copy link
Contributor

@Somefive Somefive commented Jul 25, 2022 •
edited
Loading

Description of your changes

Add two metrics related addons:

  • kube-state-metrics
  • node-exporter

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.
  • Any changes about verified addons should be tested with CI script.

@Somefive Somefive changed the title Feat: metrics addons [Addon] metrics addons Jul 25, 2022
@Somefive Somefive force-pushed the feat/metrics-addons branch 2 times, most recently from 152e100 to 742f343 Compare July 25, 2022 05:45
@Somefive Somefive force-pushed the feat/metrics-addons branch 4 times, most recently from 14696de to dc27eb9 Compare July 26, 2022 08:59
@Somefive Somefive force-pushed the feat/metrics-addons branch 2 times, most recently from 7796382 to 605a27e Compare July 26, 2022 13:00
@Somefive
Feat: add kube-state-metrics & node-exporter & fix e2e test bug
cc10f02 
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
@charlie0129 charlie0129 mentioned this pull request Jul 27, 2022
Closed
@Somefive
Fix: downgrade core dependency
3ca143a 
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
wangyikewxgm
wangyikewxgm approved these changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@wangyikewxgm wangyikewxgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Somefive Somefive merged commit 5095e7c into kubevela:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonderflow wonderflow wonderflow left review comments

@barnettZQG barnettZQG barnettZQG left review comments

@charlie0129 charlie0129 charlie0129 left review comments

@wangyikewxgm wangyikewxgm wangyikewxgm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Somefive @wonderflow @barnettZQG @charlie0129 @wangyikewxgm