Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon] refactor fluxcd to use vela-native components #422

Merged
merged 15 commits into from
Jul 28, 2022

Conversation

charlie0129
Copy link
Member

@charlie0129 charlie0129 commented Jul 26, 2022

Description of your changes

Compatibility:

  • Require vela v1.5. This is a breaking change, so we bump addon version to v2.0.0
  • Users are able to upgrade fluxcd from previous addon versions.
  • Existing e2e test makefiles in KubeVela will continue to work. (make e2e-setup use labels to wait for fluxcd to be ready. These labels are kept.)

Fixes kubevela/kubevela#3856

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.
  • Any changes about verified addons should be tested with CI script.

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
@charlie0129 charlie0129 marked this pull request as ready for review July 26, 2022 11:41
@charlie0129 charlie0129 changed the title [Addon]: refactor fluxcd to use vela-native components [Addon] refactor fluxcd to use vela-native components Jul 26, 2022
@charlie0129 charlie0129 marked this pull request as draft July 26, 2022 11:45
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
@charlie0129 charlie0129 marked this pull request as ready for review July 26, 2022 11:52
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
@wangyikewxgm
Copy link
Collaborator

Discussed with @Somefive , let's use webservice component. Worker is stale.

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
@charlie0129
Copy link
Member Author

Refactored with webservice components

wangyikewxgm
wangyikewxgm previously approved these changes Jul 27, 2022
Copy link
Collaborator

@wangyikewxgm wangyikewxgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,great job

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
@charlie0129 charlie0129 marked this pull request as draft July 27, 2022 12:57
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
@charlie0129 charlie0129 marked this pull request as ready for review July 28, 2022 06:23
@wangyikewxgm wangyikewxgm merged commit b3ba607 into kubevela:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants