-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Addon] vela core shard manager #606
Merged
chivalryq
merged 6 commits into
kubevela:master
from
Somefive:addon/vela-core-shard-manager
Feb 24, 2023
Merged
[Addon] vela core shard manager #606
chivalryq
merged 6 commits into
kubevela:master
from
Somefive:addon/vela-core-shard-manager
Feb 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somefive
requested review from
wangyikewxgm,
wonderflow and
barnettZQG
as code owners
January 20, 2023 08:24
4 tasks
Somefive
changed the title
Feat: add vela core shard manager
[Addon] vela core shard manager
Jan 20, 2023
wonderflow
reviewed
Jan 28, 2023
wonderflow
reviewed
Jan 28, 2023
Somefive
force-pushed
the
addon/vela-core-shard-manager
branch
5 times, most recently
from
January 31, 2023 12:14
7957b74
to
abd85e9
Compare
wonderflow
previously approved these changes
Jan 31, 2023
wangyikewxgm
reviewed
Feb 1, 2023
wangyikewxgm
previously approved these changes
Feb 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Somefive
force-pushed
the
addon/vela-core-shard-manager
branch
from
February 7, 2023 02:24
6f71f2e
to
a165417
Compare
wangyikewxgm
previously approved these changes
Feb 13, 2023
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Somefive
force-pushed
the
addon/vela-core-shard-manager
branch
from
February 24, 2023 02:31
0ba6bc6
to
4947588
Compare
wangyikewxgm
approved these changes
Feb 24, 2023
barnettZQG
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yin Da yd219913@alibaba-inc.com
Description of your changes
How has this code been tested?
Checklist
I have:
[Addon]
,[example]
or[Doc]
).version
inmetadata.yaml
to generate a new version.Verified Addon promotion rules
If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:
metadata.yaml
.README.md
.