Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon] vela core shard manager #606

Merged
merged 6 commits into from
Feb 24, 2023

Conversation

Somefive
Copy link
Contributor

@Somefive Somefive commented Jan 20, 2023

Signed-off-by: Yin Da yd219913@alibaba-inc.com

Description of your changes

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

@Somefive Somefive changed the title Feat: add vela core shard manager [Addon] vela core shard manager Jan 20, 2023
@Somefive Somefive force-pushed the addon/vela-core-shard-manager branch 5 times, most recently from 7957b74 to abd85e9 Compare January 31, 2023 12:14
wonderflow
wonderflow previously approved these changes Jan 31, 2023
wangyikewxgm
wangyikewxgm previously approved these changes Feb 2, 2023
Copy link
Collaborator

@wangyikewxgm wangyikewxgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
wangyikewxgm
wangyikewxgm previously approved these changes Feb 13, 2023
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
@Somefive Somefive force-pushed the addon/vela-core-shard-manager branch from 0ba6bc6 to 4947588 Compare February 24, 2023 02:31
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chivalryq chivalryq merged commit 87b346a into kubevela:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants