Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Postgres-operator #615

Merged
merged 10 commits into from
Feb 5, 2023
Merged

Conversation

MdSahil-oss
Copy link
Member

@MdSahil-oss MdSahil-oss commented Jan 31, 2023

Description of your changes

Addon Postgres-operator

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

@MdSahil-oss
Copy link
Member Author

@wonderflow I'm getting an error of Unhealthy Fetch repository successfully whenever i'm trying to build addon with helm chart, Am I missing somthing that I need to add, If so can you refer me to the doc.

@wangyikewxgm
Copy link
Collaborator

@wonderflow I'm getting an error of Unhealthy Fetch repository successfully whenever i'm trying to build addon with helm chart, Am I missing somthing that I need to add, If so can you refer me to the doc.

I found that the helm chart specified is not exist in this repo when I tested in local:

NAME                            CHART VERSION   APP VERSION     DESCRIPTION                                       
postgress/postgres-operator     1.9.0           1.9.0           Postgres Operator creates and manages PostgreSQ...

Can you check it?

@MdSahil-oss
Copy link
Member Author

Hi! @wangyikewxgm Yes! It's existing and I figured out what was the problem, now I'm able to install postgres-operator with the helm.

Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@MdSahil-oss
Copy link
Member Author

@wangyikewxgm @wonderflow I've added the definition for the postgres-operator can you review it :)

wangyikewxgm
wangyikewxgm previously approved these changes Feb 2, 2023
Copy link
Collaborator

@wangyikewxgm wangyikewxgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!I think there is still room for improvement to increase the availability of this addon.

@wangyikewxgm
Copy link
Collaborator

wangyikewxgm commented Feb 2, 2023

Can you add a sample app YAML in the examples directory and provide a comprehensive introduction in the README.md file? BackStage addon is a good example.

Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@MdSahil-oss MdSahil-oss changed the title WIP:Addon Postgres-operator Addon Postgres-operator Feb 4, 2023
@wonderflow wonderflow merged commit c92fb8f into kubevela:master Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants