Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Rabbitmq-operator #634

Merged
merged 18 commits into from
Mar 10, 2023
Merged

Conversation

MdSahil-oss
Copy link
Member

@MdSahil-oss MdSahil-oss commented Feb 11, 2023

Description of your changes

adds Addon Rabbitmq-operator

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@MdSahil-oss MdSahil-oss changed the title WIP: Addon Rabbitmq-operator Addon Rabbitmq-operator Feb 12, 2023
@MdSahil-oss
Copy link
Member Author

@wonderflow @wangyikewxgm This addon works fine and done from my side let me know if you find any to be changed.

Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@MdSahil-oss
Copy link
Member Author

@charlie0129 @wangyikewxgm I've fixed error and updated as per your suggestion

@MdSahil-oss MdSahil-oss requested review from wangyikewxgm and charlie0129 and removed request for wangyikewxgm and charlie0129 February 13, 2023 06:55
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@MdSahil-oss
Copy link
Member Author

@wangyikewxgm I've added the documentation for connection.

Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@MdSahil-oss MdSahil-oss requested review from wonderflow and wangyikewxgm and removed request for wonderflow and wangyikewxgm February 21, 2023 09:36
@MdSahil-oss
Copy link
Member Author

Hi! @wonderflow I've added instruction in README to :

  • Create a nodeport service instead of direct port-forward.
  • Access The Management UI.
  • Connect perf-test ( perf-test application is frequently used within the RabbitMQ community for load testing RabbitMQ Clusters) to the Rabbitmq Cluster.

If you still want me to build images of consumer/producers I'll do that but before to start want some answers:

  • Where to build Producer/Consumer images means in which repository should I write code? As I can see this repository is addon specific so it won't be good for writing code to build images .
  • Which programming language should I use python, golang or something else to write code?
  • and after building producer/consumer images where to push it so that images officially used by kubevela ?

I hope you will understand my all questions, If anything I missed to ask which is important Please answer that too :)

@wonderflow
Copy link
Collaborator

Hi! @wonderflow I've added instruction in README to :

  • Create a nodeport service instead of direct port-forward.
  • Access The Management UI.
  • Connect perf-test ( perf-test application is frequently used within the RabbitMQ community for load testing RabbitMQ Clusters) to the Rabbitmq Cluster.

If you still want me to build images of consumer/producers I'll do that but before to start want some answers:

  • Where to build Producer/Consumer images means in which repository should I write code? As I can see this repository is addon specific so it won't be good for writing code to build images .
  • Which programming language should I use python, golang or something else to write code?
  • and after building producer/consumer images where to push it so that images officially used by kubevela ?

I hope you will understand my all questions, If anything I missed to ask which is important Please answer that too :)

You're doing really great job! I've created a repo and invited you as one of the project members: https://github.com/kubevela-contrib/addon-samples . We can write sample code/yaml in this project and build images using the github registry.

@MdSahil-oss
Copy link
Member Author

Thanks @wonderflow for answering my questions and making me member of the repository, Very soon I'll be building images using Golang & asking you more about github registry to push images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants