Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Koordinator #643

Merged
merged 22 commits into from
Mar 10, 2023
Merged

Addon Koordinator #643

merged 22 commits into from
Mar 10, 2023

Conversation

MdSahil-oss
Copy link
Member

@MdSahil-oss MdSahil-oss commented Feb 22, 2023

Description of your changes

Adds Koordinator as an addon

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@MdSahil-oss MdSahil-oss changed the title WIP: Addon Koordinator Addon Koordinator Feb 24, 2023
@MdSahil-oss
Copy link
Member Author

@wangyikewxgm @wonderflow This addon is done from my side, Please review it and let me know if I have to change or improve something :)

@wonderflow
Copy link
Collaborator

ping @FillZpp

Copy link

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work.

experimental/addons/koordinator/README.md Outdated Show resolved Hide resolved
experimental/addons/koordinator/README.md Outdated Show resolved Hide resolved
experimental/addons/koordinator/README.md Outdated Show resolved Hide resolved
experimental/addons/koordinator/README.md Show resolved Hide resolved
Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to add definitions of Device, NodeSLO and NodeMetric, which are internal CRDs and all their CRs are created by koord-manager instead of users.

experimental/addons/koordinator/README.md Outdated Show resolved Hide resolved
experimental/addons/koordinator/README.md Outdated Show resolved Hide resolved
examples/koordinator/koordinator-colocation-profile.yaml Outdated Show resolved Hide resolved
examples/koordinator/koordinator-colocation-profile.yaml Outdated Show resolved Hide resolved
experimental/addons/koordinator/metadata.yaml Outdated Show resolved Hide resolved
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@MdSahil-oss
Copy link
Member Author

@eahydra I've updated Readme for Fine-grained CPU Orchestration and Load Aware Scheduling scenes, would you like to have a look on that ?

Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM, ping @eahydra @FillZpp

@eahydra
Copy link

eahydra commented May 19, 2023

@eahydra I've updated Readme for Fine-grained CPU Orchestration and Load Aware Scheduling scenes, would you like to have a look on that ?

@MdSahil-oss Thanks! Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants