Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Kruise game #672

Merged
merged 27 commits into from
Apr 23, 2023
Merged

Addon Kruise game #672

merged 27 commits into from
Apr 23, 2023

Conversation

MdSahil-oss
Copy link
Member

@MdSahil-oss MdSahil-oss commented Apr 14, 2023

Description of your changes

Adds OpenKruiseGame as an addon
Fixes kubevela/kubevela#5793

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@MdSahil-oss
Copy link
Member Author

@wonderflow @wangyikewxgm This addon is done, Please review it.

@MdSahil-oss MdSahil-oss changed the title WIP Addon Kruise game Addon Kruise game Apr 18, 2023
Copy link
Contributor

@Somefive Somefive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I would recommend several modifications:

  1. Move kruise-game from experimental/addons to addons. Let's make it an official one.
  2. The workflow step should use the deploy step. apply-component step you used here cannot make multicluster deploy effective.
  3. The helm chart version should be extracted as a standalone parameter in parameter.cue.
  4. Do not embed kruise directly in the kruise-game addon. Leverage the existing kruise addon.
  5. Add the resource relation below.
apiVersion: v1
kind: ConfigMap
metadata:
  labels:
    rules.oam.dev/resource-format: yaml
    rules.oam.dev/resources: "true"
  name: game-server-set-relation
data:
  rules: |-
    - parentResourceType:
        group: game.kruise.io
        kind: GameServerSet
      childrenResourceType:
        - apiVersion: apps.kruise.io/v1beta1
          kind: StatefulSet
        - apiVersion: game.kruise.io/v1alpha1
          kind: GameServer
    - parentResourceType:
        group: apps.kruise.io
        kind: StatefulSet
      childrenResourceType:
        - apiVersion: v1
          kind: Pod

Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@MdSahil-oss
Copy link
Member Author

@wonderflow Please review this PR again I've made changes as per your suggestions :)

@Somefive
Copy link
Contributor

It looks good. I will later validate it again in multicluster scenario. There is some trouble with CI because it depends on Kruise but Kruise is in the experimental part. So I guess we need to make it an experimental one for now. Then we can move both kruise and kruise-game from the experimental to the official folders.

Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! BTW, you can add topology for other addons if you'd like to. Thanks!

@wonderflow wonderflow merged commit e011c70 into kubevela:master Apr 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support OpenKruiseGame as addon
3 participants