-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon Kruise game #672
Addon Kruise game #672
Conversation
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@wonderflow @wangyikewxgm This addon is done, Please review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I would recommend several modifications:
- Move
kruise-game
fromexperimental/addons
toaddons
. Let's make it an official one. - The workflow step should use the deploy step.
apply-component
step you used here cannot make multicluster deploy effective. - The helm chart version should be extracted as a standalone parameter in parameter.cue.
- Do not embed
kruise
directly in thekruise-game
addon. Leverage the existingkruise
addon. - Add the resource relation below.
apiVersion: v1
kind: ConfigMap
metadata:
labels:
rules.oam.dev/resource-format: yaml
rules.oam.dev/resources: "true"
name: game-server-set-relation
data:
rules: |-
- parentResourceType:
group: game.kruise.io
kind: GameServerSet
childrenResourceType:
- apiVersion: apps.kruise.io/v1beta1
kind: StatefulSet
- apiVersion: game.kruise.io/v1alpha1
kind: GameServer
- parentResourceType:
group: apps.kruise.io
kind: StatefulSet
childrenResourceType:
- apiVersion: v1
kind: Pod
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@wonderflow Please review this PR again I've made changes as per your suggestions :) |
It looks good. I will later validate it again in multicluster scenario. There is some trouble with CI because it depends on Kruise but Kruise is in the experimental part. So I guess we need to make it an experimental one for now. Then we can move both |
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! BTW, you can add topology for other addons if you'd like to. Thanks!
Description of your changes
Adds OpenKruiseGame as an addon
Fixes kubevela/kubevela#5793
How has this code been tested?
Checklist
I have:
[Addon]
,[example]
or[Doc]
).version
inmetadata.yaml
to generate a new version.Verified Addon promotion rules
If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:
metadata.yaml
.README.md
.