Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Bytebase #679

Merged
merged 22 commits into from
Apr 25, 2023
Merged

Addon Bytebase #679

merged 22 commits into from
Apr 25, 2023

Conversation

MdSahil-oss
Copy link
Member

@MdSahil-oss MdSahil-oss commented Apr 22, 2023

Description of your changes

Adds bytebase as an addon
Fixes kubevela/kubevela#5878

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@MdSahil-oss MdSahil-oss changed the title WIP: Addon Bytebase Addon Bytebase Apr 24, 2023
@MdSahil-oss
Copy link
Member Author

@wonderflow Please review this addon again.

Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
tianzhou
tianzhou previously approved these changes Apr 24, 2023
Copy link

@tianzhou tianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @MdSahil-oss thanks for adding Bytebase to kubevela !

Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

wonderflow
wonderflow previously approved these changes Apr 25, 2023
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@MdSahil-oss
Copy link
Member Author

@wonderflow I've removed fluxcd dependency.

@wonderflow wonderflow merged commit f48440c into kubevela:master Apr 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support Bytebase as KubeVela addon
3 participants