Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Jaeger-operator #690

Merged
merged 25 commits into from
Jun 30, 2023
Merged

Conversation

MdSahil-oss
Copy link
Member

@MdSahil-oss MdSahil-oss commented May 15, 2023

Description of your changes

Adds jaeger-operator as addon
kubevela/kubevela#5971

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@MdSahil-oss
Copy link
Member Author

@wangyikewxgm @wonderflow Please review this addon.

@MdSahil-oss MdSahil-oss changed the title WIP Addon Jaeger-operator Addon Jaeger-operator May 17, 2023
@wangyikewxgm
Copy link
Collaborator

Does Jaeger not have a Helm chart? It would be more convenient to import a Helm chart instead of having such a large template.cue file, which can be difficult to modify.

Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@MdSahil-oss
Copy link
Member Author

@wangyikewxgm Added helm installation support.

Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@wonderflow wonderflow merged commit 4c1aacb into kubevela:master Jun 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants