Feat: support leader election for kube-trigger #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangsoon
requested review from
FogDong,
charlie0129 and
Somefive
as code owners
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 73.19% 73.30% +0.11%
==========================================
Files 13 15 +2
Lines 1134 1195 +61
==========================================
+ Hits 830 876 +46
- Misses 262 275 +13
- Partials 42 44 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
yangsoon
force-pushed
the
feature/support-leaderelection
branch
from
8e3ab76
to
c337b56
Compare
charlie0129
reviewed
Apr 17, 2023
Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
yangsoon
force-pushed
the
feature/support-leaderelection
branch
from
c337b56
to
94cb439
Compare
semmet95
pushed a commit
to semmet95/kube-trigger
that referenced
this pull request
May 10, 2023
Signed-off-by: yangsoon <songyang.song@alibaba-inc.com> Co-authored-by: yangsoon <songyang.song@alibaba-inc.com> Signed-off-by: Amit Singh <singhamitch@outlook.com>
semmet95
pushed a commit
to semmet95/kube-trigger
that referenced
this pull request
May 10, 2023
Signed-off-by: yangsoon <songyang.song@alibaba-inc.com> Co-authored-by: yangsoon <songyang.song@alibaba-inc.com> Signed-off-by: Amit Singh <singhamitch@outlook.com>
semmet95
pushed a commit
to semmet95/kube-trigger
that referenced
this pull request
May 10, 2023
Signed-off-by: yangsoon <songyang.song@alibaba-inc.com> Co-authored-by: yangsoon <songyang.song@alibaba-inc.com> Signed-off-by: Amit Singh <singhamitch@outlook.com>
semmet95
pushed a commit
to semmet95/kube-trigger
that referenced
this pull request
May 10, 2023
Signed-off-by: yangsoon <songyang.song@alibaba-inc.com> Co-authored-by: yangsoon <songyang.song@alibaba-inc.com> Signed-off-by: Amit Singh <singhamitch@outlook.com>
semmet95
pushed a commit
to semmet95/kube-trigger
that referenced
this pull request
May 10, 2023
Signed-off-by: yangsoon <songyang.song@alibaba-inc.com> Co-authored-by: yangsoon <songyang.song@alibaba-inc.com>
semmet95
pushed a commit
to semmet95/kube-trigger
that referenced
this pull request
May 11, 2023
Signed-off-by: yangsoon <songyang.song@alibaba-inc.com> Co-authored-by: yangsoon <songyang.song@alibaba-inc.com> Signed-off-by: Amit Singh <singhamitch@outlook.com>
semmet95
added a commit
to semmet95/kube-trigger
that referenced
this pull request
May 19, 2023
This reverts commit 4351008. Removing changes unrelated to this branch
semmet95
added a commit
to semmet95/kube-trigger
that referenced
this pull request
May 19, 2023
This reverts commit 4351008. Removing changes unrelated to this branch Signed-off-by: Amit Singh <singhamitch@outlook.com>
FogDong
pushed a commit
that referenced
this pull request
May 19, 2023
* Feat: upgrade k8s.io dependency to 0.26 (#39) * Feat: upgrade k8s.io dependency to 0.26 Signed-off-by: Yin Da <yd219913@alibaba-inc.com> * Fix: golangci-lint action failure Signed-off-by: Yin Da <yd219913@alibaba-inc.com> --------- Signed-off-by: Yin Da <yd219913@alibaba-inc.com> Signed-off-by: Amit Singh <singhamitch@outlook.com> * Feat: add cluster info to action context (#43) Feat: add cluster info in action context Signed-off-by: yangsoon <songyang.song@alibaba-inc.com> Co-authored-by: yangsoon <songyang.song@alibaba-inc.com> Signed-off-by: Amit Singh <singhamitch@outlook.com> * Feat: add cronjob source (#42) * Refactor: allow the use of singleton for one Source, while also allowing non-singleton Sources, making it more extensible Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * Feat: add cronjob source Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * Chore: update cron lib Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * Feat: do not exit if config contains invalid sources Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * Chore: add tests and fix linter Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * Chore: go mod tidy Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * Docs: add cronjob example Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * fix comments Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * Chore: force lint to use the exact version Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * remove unnecessary dep Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * fix comments Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * use codecov token Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> * update lint script Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> --------- Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> Signed-off-by: Amit Singh <singhamitch@outlook.com> * Feat: support leader election for kube-trigger (#45) Signed-off-by: yangsoon <songyang.song@alibaba-inc.com> Co-authored-by: yangsoon <songyang.song@alibaba-inc.com> Signed-off-by: Amit Singh <singhamitch@outlook.com> * adds instruction to enable kube-trigger addon Signed-off-by: Amit Singh <singhamitch@outlook.com> * updates sample.yaml path Signed-off-by: Amit Singh <singhamitch@outlook.com> * fix: updates instructions to apply config files in order Signed-off-by: Amit Singh <singhamitch@outlook.com> * fix: adds the missing api group to the first rule Signed-off-by: Amit Singh <singhamitch@outlook.com> * Revert "Feat: support leader election for kube-trigger (#45)" This reverts commit 4351008. Removing changes unrelated to this branch Signed-off-by: Amit Singh <singhamitch@outlook.com> * Revert "Feat: add cronjob source (#42)" This reverts commit 46f5975. Removes changes unrelated to the branch Signed-off-by: Amit Singh <singhamitch@outlook.com> * Revert "Feat: add cluster info to action context (#43)" This reverts commit e214be5. Removes changes unrelated to the branch Signed-off-by: Amit Singh <singhamitch@outlook.com> * Revert "Feat: upgrade k8s.io dependency to 0.26 (#39)" This reverts commit a22e316. Removes changes unrelated to the branch Signed-off-by: Amit Singh <singhamitch@outlook.com> --------- Signed-off-by: Yin Da <yd219913@alibaba-inc.com> Signed-off-by: Amit Singh <singhamitch@outlook.com> Signed-off-by: yangsoon <songyang.song@alibaba-inc.com> Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> Co-authored-by: Somefive <Somefive@foxmail.com> Co-authored-by: yangs <yangsoonlx@gmail.com> Co-authored-by: yangsoon <songyang.song@alibaba-inc.com> Co-authored-by: Charlie Chiang <charlie_c_0129@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
support leader election for kube-trigger
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer