How to update an existing application when a the definition of a trait is updated #1810
Answered
by
alexis-wefight
alexis-wefight
asked this question in
Q&A
-
|
Hi, I am currently exploring Kubevela, and when I update an existing trait configuration (defined with cue), updates are not propagated to applications using this trait. Is there a way to automatically update the applications when an existing trait is modified? The workaround I use is to delete the application and to apply it again, but it is a bit silly. I'm not totally comfortable with how Kubevela manage applications and updates and I was not able to find this information in the documentation. Thank you for your help. |
Beta Was this translation helpful? Give feedback.
Answered by
alexis-wefight
Jun 24, 2021
Replies: 3 comments 9 replies
-
|
When change definition, you will have new versions, you can specify definition revision in application https://kubevela.io/docs/platform-engineers/definition-and-templates#specify-definition-revision-in-application |
Beta Was this translation helpful? Give feedback.
3 replies
-
|
@wonderflow Thanks for your answer. I tried to following:
Is there a way to automatically update resources created when the template itself is updated (the "ingress-tls" trait in the current use case)? Please correct me if I misunderstood how kubevela works. Thank you. |
Beta Was this translation helpful? Give feedback.
-
|
Any suggestion? I'm still not able to understand how Kubevela (and OAM) manage traits and components updates for existing applications using the same updated components/traits. Thanks for your help. |
Beta Was this translation helpful? Give feedback.
-
|
What's the version of KubeVela? In your case, the ingress should be updated after the last step by specifying the version of definition. Currently, if application object has no change, vela didn't have a mechanism to trigger upgrade automatically. |
Beta Was this translation helpful? Give feedback.
-
|
Could you provide us with the status in the Application? If the status field of Application is normal, please provide the relevant yaml file to reproduce this problem, I also hope you can provide the version of KubeVela. |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
Hi @wonderflow @yangsoon, thanks for your answer. I retried to update the "ingress-tls" trait but the application is not updated even when I specify the new revision of the "ingress-tls. The application status seems to be empty: I use the version 1.0.6: Here are the yaml resources impacted:
kubectl get traitdefinition ingress-tls -n vela-system -o yaml
apiVersion: core.oam.dev/v1beta1
kind: TraitDefinition
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"core.oam.dev/v1beta1","kind":"TraitDefinition","metadata":{"annotations":{},"name":"ingress-tls","namespace":"vela-system"},"spec":{"appliesToWorkloads":["webservice","worker"],"podDisruptive":false,"schematic":{"cue":{"template":"parameter: {\n domain: string\n http: [string]: int\n annotations: [string]: string\n}\n\n// trait template can have multiple outputs in one trait\n\n\noutputs: ingress: {\n if parameter.domain != _|_ {\n apiVersion: \"networking.k8s.io/v1\"\n kind: \"Ingress\"\n metadata: {\n name: context.name\n annotations: {\n \"cert-manager.io/cluster-issuer\": \"letsencrypt-prod\"\n \"kubernetes.io/ingress.class\": \"traefik\"\n \"traefik.ingress.kubernetes.io/router.entrypoints\": \"web,websecure\"\n \"traefik.ingress.kubernetes.io/router.tls\": \"true\"\n for k, v in parameter.annotations {\n k: v\n }\n \"traefik.ingress.kubernetes.io/router.middlewares\": \"traefik-ip-whitelist-montpellier@kubernetescrd\"\n }\n\n }\n spec: {\n tls: [{\n hosts: [ parameter.domain ]\n secretName: parameter.domain\n }]\n rules: [{\n host: parameter.domain\n http: {\n paths: [\n for k, v in parameter.http {\n path: k\n pathType: \"Prefix\"\n backend: {\n service: {\n name: context.name\n port: number: v\n } \n }\n }\n ]\n }\n }]\n }\n }\n}\n"}}}}
creationTimestamp: "2021-06-21T16:56:49Z"
generation: 6
name: ingress-tls
namespace: vela-system
resourceVersion: "288681"
uid: 70813fa0-1afc-48ff-b239-98619487abec
spec:
appliesToWorkloads:
- webservice
- worker
podDisruptive: false
schematic:
cue:
template: "parameter: {\n domain: string\n http: [string]: int\n annotations:
[string]: string\n}\n\n// trait template can have multiple outputs in one
trait\n\n\noutputs: ingress: {\n if parameter.domain != _|_ {\n apiVersion:
\"networking.k8s.io/v1\"\n kind: \"Ingress\"\n metadata: {\n name:
context.name\n annotations: {\n \"cert-manager.io/cluster-issuer\":
\"letsencrypt-prod\"\n \"kubernetes.io/ingress.class\": \"traefik\"\n
\ \"traefik.ingress.kubernetes.io/router.entrypoints\": \"web,websecure\"\n
\ \"traefik.ingress.kubernetes.io/router.tls\": \"true\"\n for
k, v in parameter.annotations {\n k: v\n }\n \"traefik.ingress.kubernetes.io/router.middlewares\":
\"traefik-ip-whitelist-montpellier@kubernetescrd\"\n }\n\n }\n spec:
{\n tls: [{\n hosts: [ parameter.domain ]\n secretName:
parameter.domain\n }]\n rules: [{\n host: parameter.domain\n
\ http: {\n paths: [\n for k,
v in parameter.http {\n path: k\n pathType:
\"Prefix\"\n backend: {\n service:
{\n name: context.name\n port:
number: v\n } \n }\n }\n
\ ]\n }\n }]\n }\n }\n}\n"
status:
configMapRef: schema-ingress-tls
latestRevision:
name: ingress-tls-v6
revision: 6
revisionHash: 45b77db098ffe412
kubectl get application.c -n hello-world -o yaml
apiVersion: v1
items:
- apiVersion: core.oam.dev/v1beta1
kind: Application
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"core.oam.dev/v1beta1","kind":"Application","metadata":{"annotations":{},"name":"webserver-demo","namespace":"hello-world"},"spec":{"components":[{"name":"hello-world","properties":{"cpu":"100m","env":[{"name":"foo","value":"bar"}],"image":"crccheck/hello-world","port":8000},"traits":[{"properties":{"annotations":{"traefik.ingress.kubernetes.io/router.middlewares":"traefik-ip-whitelist-montpellier@kubernetescrd"},"domain":"hello-world.dev.wefight-test.com","http":{"/":8000}},"type":"ingress-tls@v6"},{"properties":{"min":2},"type":"hpa"},{"properties":{"toto":"titi","tutu":"toto"},"type":"labels"},{"properties":{"toto":"titi","tutu":"toto"},"type":"annotations"}],"type":"webserver"}]}}
creationTimestamp: "2021-06-22T08:01:47Z"
generation: 5
name: webserver-demo
namespace: hello-world
resourceVersion: "288770"
uid: 08ec4dd5-091c-4b84-bd4a-8dfb6a0e1c85
spec:
components:
- name: hello-world
properties:
cpu: 100m
env:
- name: foo
value: bar
image: crccheck/hello-world
port: 8000
traits:
- properties:
annotations:
traefik.ingress.kubernetes.io/router.middlewares: traefik-ip-whitelist-montpellier@kubernetescrd
domain: hello-world.dev.wefight-test.com
http:
/: 8000
type: ingress-tls@v6
- properties:
min: 2
type: hpa
- properties:
toto: titi
tutu: toto
type: labels
- properties:
toto: titi
tutu: toto
type: annotations
type: webserver
status:
components:
- apiVersion: core.oam.dev/v1alpha2
kind: Component
name: hello-world
uid: 08ec4dd5-091c-4b84-bd4a-8dfb6a0e1c85
conditions:
- lastTransitionTime: "2021-06-22T08:01:47Z"
reason: Available
status: "True"
type: Parsed
- lastTransitionTime: "2021-06-22T08:01:47Z"
reason: Available
status: "True"
type: Built
- lastTransitionTime: "2021-06-22T08:01:49Z"
reason: Available
status: "True"
type: Applied
- lastTransitionTime: "2021-06-22T08:01:49Z"
reason: Available
status: "True"
type: HealthCheck
latestRevision:
name: webserver-demo-v6
revision: 6
revisionHash: 10e303417a684620
rollout:
batchRollingState: ""
currentBatch: 0
lastTargetAppRevision: ""
rollingState: ""
upgradedReadyReplicas: 0
upgradedReplicas: 0
services:
- healthy: true
name: hello-world
traits:
- healthy: true
type: ingress-tls@v6
- healthy: true
type: hpa
- healthy: true
type: labels
- healthy: true
type: annotations
workloadDefinition:
apiVersion: apps/v1
kind: Deployment
status: running
kind: List
metadata:
resourceVersion: ""
selfLink: ""
kubectl get ingress -n hello-world -o yaml
apiVersion: v1
items:
- apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
annotations:
app.oam.dev/generation: "0"
app.oam.dev/last-applied-configuration: '{"apiVersion":"networking.k8s.io/v1","kind":"Ingress","metadata":{"annotations":{"app.oam.dev/generation":"0","cert-manager.io/cluster-issuer":"letsencrypt-staging","k":"traefik-ip-whitelist-montpellier@kubernetescrd","kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"core.oam.dev/v1beta1\",\"kind\":\"Application\",\"metadata\":{\"annotations\":{},\"name\":\"webserver-demo\",\"namespace\":\"hello-world\"},\"spec\":{\"components\":[{\"name\":\"hello-world\",\"properties\":{\"cpu\":\"100m\",\"env\":[{\"name\":\"foo\",\"value\":\"bar\"}],\"image\":\"crccheck/hello-world\",\"port\":8000},\"traits\":[{\"properties\":{\"annotations\":{\"traefik.ingress.kubernetes.io/router.middlewares\":\"traefik-ip-whitelist-montpellier@kubernetescrd\"},\"domain\":\"hello-world.dev.wefight-test.com\",\"http\":{\"/\":8000}},\"type\":\"ingress-tls\"},{\"properties\":{\"min\":2},\"type\":\"hpa\"},{\"properties\":{\"toto\":\"titi\",\"tutu\":\"toto\"},\"type\":\"labels\"},{\"properties\":{\"toto\":\"titi\",\"tutu\":\"toto\"},\"type\":\"annotations\"}],\"type\":\"webserver\"}]}}\n","kubernetes.io/ingress.class":"traefik","traefik.ingress.kubernetes.io/router.entrypoints":"web,websecure","traefik.ingress.kubernetes.io/router.middlewares":"traefik-ip-whitelist-montpellier@kubernetescrd","traefik.ingress.kubernetes.io/router.tls":"true"},"labels":{"app.oam.dev/app-revision-hash":"8c0be8d8cfcc52c9","app.oam.dev/appRevision":"webserver-demo-v3","app.oam.dev/component":"hello-world","app.oam.dev/name":"webserver-demo","app.oam.dev/resourceType":"TRAIT","app.oam.dev/revision":"hello-world-v3","trait.oam.dev/resource":"ingress","trait.oam.dev/type":"ingress-tls"},"name":"hello-world","namespace":"hello-world","ownerReferences":[{"apiVersion":"core.oam.dev/v1alpha2","blockOwnerDeletion":true,"controller":true,"kind":"ApplicationContext","name":"webserver-demo","uid":"c434098b-2d52-48d2-8b3b-2e1b612d1b14"}]},"spec":{"rules":[{"host":"hello-world.dev.wefight-test.com","http":{"paths":[{"backend":{"service":{"name":"hello-world","port":{"number":8000}}},"path":"/","pathType":"Prefix"}]}}],"tls":[{"hosts":["hello-world.dev.wefight-test.com"],"secretName":"hello-world.dev.wefight-test.com"}]}}'
cert-manager.io/cluster-issuer: letsencrypt-staging
k: traefik-ip-whitelist-montpellier@kubernetescrd
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"core.oam.dev/v1beta1","kind":"Application","metadata":{"annotations":{},"name":"webserver-demo","namespace":"hello-world"},"spec":{"components":[{"name":"hello-world","properties":{"cpu":"100m","env":[{"name":"foo","value":"bar"}],"image":"crccheck/hello-world","port":8000},"traits":[{"properties":{"annotations":{"traefik.ingress.kubernetes.io/router.middlewares":"traefik-ip-whitelist-montpellier@kubernetescrd"},"domain":"hello-world.dev.wefight-test.com","http":{"/":8000}},"type":"ingress-tls"},{"properties":{"min":2},"type":"hpa"},{"properties":{"toto":"titi","tutu":"toto"},"type":"labels"},{"properties":{"toto":"titi","tutu":"toto"},"type":"annotations"}],"type":"webserver"}]}}
kubernetes.io/ingress.class: traefik
traefik.ingress.kubernetes.io/router.entrypoints: web,websecure
traefik.ingress.kubernetes.io/router.middlewares: traefik-ip-whitelist-montpellier@kubernetescrd
traefik.ingress.kubernetes.io/router.tls: "true"
creationTimestamp: "2021-06-22T08:01:49Z"
generation: 2
labels:
app.oam.dev/app-revision-hash: 8c0be8d8cfcc52c9
app.oam.dev/appRevision: webserver-demo-v3
app.oam.dev/component: hello-world
app.oam.dev/name: webserver-demo
app.oam.dev/resourceType: TRAIT
app.oam.dev/revision: hello-world-v3
trait.oam.dev/resource: ingress
trait.oam.dev/type: ingress-tls
name: hello-world
namespace: hello-world
ownerReferences:
- apiVersion: core.oam.dev/v1alpha2
blockOwnerDeletion: true
controller: true
kind: ApplicationContext
name: webserver-demo
uid: c434098b-2d52-48d2-8b3b-2e1b612d1b14
resourceVersion: "232478"
uid: 1a09e019-2cd2-43aa-b684-379dfb59136c
spec:
rules:
- host: hello-world.dev.wefight-test.com
http:
paths:
- backend:
service:
name: hello-world
port:
number: 8000
path: /
pathType: Prefix
tls:
- hosts:
- hello-world.dev.wefight-test.com
secretName: hello-world.dev.wefight-test.com
status:
loadBalancer: {}
kind: List
metadata:
resourceVersion: ""
selfLink: ""The annotation should be cert-manager.io/cluster-issuer: letsencrypt-prod and not cert-manager.io/cluster-issuer: letsencrypt-staging By the way I noticed the app.oam.dev/appRevision: webserver-demo-v3 label. I dont know if this label should be updated when the application is modified, but it does not correspond to the latest one (webserver-demo-v6). Here are both applicationsrevisions: kubectl get applicationrevisions webserver-demo-v3 -n hello-world -o yaml
apiVersion: core.oam.dev/v1beta1
kind: ApplicationRevision
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"core.oam.dev/v1beta1","kind":"Application","metadata":{"annotations":{},"name":"webserver-demo","namespace":"hello-world"},"spec":{"components":[{"name":"hello-world","properties":{"cpu":"100m","env":[{"name":"foo","value":"bar"}],"image":"crccheck/hello-world","port":8000},"traits":[{"properties":{"annotations":{"traefik.ingress.kubernetes.io/router.middlewares":"traefik-ip-whitelist-montpellier@kubernetescrd"},"domain":"hello-world.dev.wefight-test.com","http":{"/":8000}},"type":"ingress-tls"},{"properties":{"min":2},"type":"hpa"},{"properties":{"toto":"titi","tutu":"toto"},"type":"labels"},{"properties":{"toto":"titi","tutu":"toto"},"type":"annotations"}],"type":"webserver"}]}}
creationTimestamp: "2021-06-22T08:24:45Z"
generation: 1
labels:
app.oam.dev/app-revision-hash: 8c0be8d8cfcc52c9
app.oam.dev/name: webserver-demo
name: webserver-demo-v3
namespace: hello-world
ownerReferences:
- apiVersion: core.oam.dev/v1beta1
controller: false
kind: Application
name: webserver-demo
uid: 08ec4dd5-091c-4b84-bd4a-8dfb6a0e1c85
resourceVersion: "232463"
uid: 03945e22-f7b6-423b-832d-343b05fd2503
spec:
application:
apiVersion: core.oam.dev/v1beta1
kind: Application
metadata: {}
spec:
components:
- name: hello-world
properties:
cpu: 100m
env:
- name: foo
value: bar
image: crccheck/hello-world
port: 8000
traits:
- properties:
annotations:
traefik.ingress.kubernetes.io/router.middlewares: traefik-ip-whitelist-montpellier@kubernetescrd
domain: hello-world.dev.wefight-test.com
http:
/: 8000
type: ingress-tls
- properties:
min: 2
type: hpa
- properties:
toto: titi
tutu: toto
type: labels
- properties:
toto: titi
tutu: toto
type: annotations
type: webserver
status:
rollout:
batchRollingState: ""
currentBatch: 0
lastTargetAppRevision: ""
rollingState: ""
upgradedReadyReplicas: 0
upgradedReplicas: 0
applicationConfiguration:
apiVersion: core.oam.dev/v1alpha2
kind: ApplicationConfiguration
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"core.oam.dev/v1beta1","kind":"Application","metadata":{"annotations":{},"name":"webserver-demo","namespace":"hello-world"},"spec":{"components":[{"name":"hello-world","properties":{"cpu":"100m","env":[{"name":"foo","value":"bar"}],"image":"crccheck/hello-world","port":8000},"traits":[{"properties":{"annotations":{"traefik.ingress.kubernetes.io/router.middlewares":"traefik-ip-whitelist-montpellier@kubernetescrd"},"domain":"hello-world.dev.wefight-test.com","http":{"/":8000}},"type":"ingress-tls"},{"properties":{"min":2},"type":"hpa"},{"properties":{"toto":"titi","tutu":"toto"},"type":"labels"},{"properties":{"toto":"titi","tutu":"toto"},"type":"annotations"}],"type":"webserver"}]}}
labels:
app.oam.dev/name: webserver-demo
name: webserver-demo
namespace: hello-world
ownerReferences:
- apiVersion: core.oam.dev/v1beta1
controller: true
kind: Application
name: webserver-demo
uid: 08ec4dd5-091c-4b84-bd4a-8dfb6a0e1c85
spec:
components:
- revisionName: hello-world-v3
traits:
- trait:
apiVersion: v1
kind: Service
metadata:
labels:
app.oam.dev/appRevision: webserver-demo-v3
app.oam.dev/component: hello-world
app.oam.dev/name: webserver-demo
trait.oam.dev/resource: service
trait.oam.dev/type: AuxiliaryWorkload
name: hello-world
spec:
ports:
- port: 8000
targetPort: 8000
selector:
app.oam.dev/component: hello-world
- trait:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
annotations:
cert-manager.io/cluster-issuer: letsencrypt-staging
k: traefik-ip-whitelist-montpellier@kubernetescrd
kubernetes.io/ingress.class: traefik
traefik.ingress.kubernetes.io/router.entrypoints: web,websecure
traefik.ingress.kubernetes.io/router.middlewares: traefik-ip-whitelist-montpellier@kubernetescrd
traefik.ingress.kubernetes.io/router.tls: "true"
labels:
app.oam.dev/appRevision: webserver-demo-v3
app.oam.dev/component: hello-world
app.oam.dev/name: webserver-demo
trait.oam.dev/resource: ingress
trait.oam.dev/type: ingress-tls
name: hello-world
spec:
rules:
- host: hello-world.dev.wefight-test.com
http:
paths:
- backend:
service:
name: hello-world
port:
number: 8000
path: /
pathType: Prefix
tls:
- hosts:
- hello-world.dev.wefight-test.com
secretName: hello-world.dev.wefight-test.com
- trait:
apiVersion: autoscaling/v2beta2
kind: HorizontalPodAutoscaler
metadata:
labels:
app.oam.dev/appRevision: webserver-demo-v3
app.oam.dev/component: hello-world
app.oam.dev/name: webserver-demo
trait.oam.dev/resource: hpa
trait.oam.dev/type: hpa
name: hello-world
spec:
maxReplicas: 6
metrics:
- resource:
name: cpu
target:
averageUtilization: 50
type: Utilization
type: Resource
minReplicas: 2
scaleTargetRef:
apiVersion: apps/v1
kind: Deployment
name: hello-world
status:
dependency: {}
observedGeneration: 0
componentDefinitions:
webserver:
apiVersion: core.oam.dev/v1beta1
kind: ComponentDefinition
metadata: {}
spec:
schematic:
cue:
template: "output: {\n apiVersion: \"apps/v1\"\n kind: \"Deployment\"\n
\ spec: {\n selector: matchLabels: {\n \"app.oam.dev/component\":
context.name\n }\n template: {\n metadata:
{\n name: context.name \n labels: {\n \"app.oam.dev/component\":
context.name\n }\n annotations: {\n \"app.oam.dev/component\":
context.name\n }\n }\n spec: {\n
\ containers: [{\n name: context.name\n
\ image: parameter.image\n\n if
parameter[\"cmd\"] != _|_ {\n command: parameter.cmd\n
\ }\n\n if parameter[\"env\"] !=
_|_ {\n env: parameter.env\n }\n\n
\ if context[\"config\"] != _|_ {\n env:
context.config\n }\n\n ports:
[{\n containerPort: parameter.port\n }]\n\n
\ if parameter[\"cpu\"] != _|_ {\n resources:
{\n limits:\n cpu:
parameter.cpu\n requests:\n cpu:
parameter.cpu\n }\n }\n }]\n
\ }\n }\n }\n}\n// an extra template\noutputs: service:
{\n apiVersion: \"v1\"\n kind: \"Service\"\n metadata:
{\n name: context.name\n }\n spec: {\n selector: {\n
\ \"app.oam.dev/component\": context.name\n }\n ports:
[\n {\n port: parameter.port\n targetPort:
parameter.port\n },\n ]\n }\n}\nparameter: {\n
\ image: string\n cmd?: [...string]\n port: *80 | int\n env?:
[...{\n name: string\n value?: string\n valueFrom?:
{\n secretKeyRef: {\n name: string\n key:
\ string\n }\n }\n }]\n cpu?: string\n}\n"
workload:
definition:
apiVersion: apps/v1
kind: Deployment
status: {}
components:
- raw:
apiVersion: core.oam.dev/v1alpha2
kind: Component
metadata:
labels:
app.oam.dev/name: webserver-demo
name: hello-world
namespace: hello-world
ownerReferences:
- apiVersion: core.oam.dev/v1beta1
controller: true
kind: Application
name: webserver-demo
uid: 08ec4dd5-091c-4b84-bd4a-8dfb6a0e1c85
spec:
workload:
apiVersion: apps/v1
kind: Deployment
metadata:
labels:
app.oam.dev/appRevision: webserver-demo-v3
app.oam.dev/component: hello-world
app.oam.dev/name: webserver-demo
workload.oam.dev/type: webserver
spec:
selector:
matchLabels:
app.oam.dev/component: hello-world
template:
metadata:
annotations:
app.oam.dev/component: hello-world
toto: titi
tutu: toto
labels:
app.oam.dev/component: hello-world
toto: titi
tutu: toto
name: hello-world
spec:
containers:
- env:
- name: foo
value: bar
image: crccheck/hello-world
name: hello-world
ports:
- containerPort: 8000
resources:
limits:
cpu: 100m
requests:
cpu: 100m
status:
observedGeneration: 0
traitDefinitions:
annotations:
apiVersion: core.oam.dev/v1beta1
kind: TraitDefinition
metadata: {}
spec:
appliesToWorkloads:
- webservice
- worker
definitionRef:
name: ""
schematic:
cue:
template: "patch: {\n\tspec: template: metadata: annotations: {\n\t\tfor
k, v in parameter {\n\t\t\t\"\\(k)\": v\n\t\t}\n\t}\n}\nparameter: [string]:
string"
status: {}
hpa:
apiVersion: core.oam.dev/v1beta1
kind: TraitDefinition
metadata: {}
spec:
appliesToWorkloads:
- deployments.apps
definitionRef:
name: ""
schematic:
cue:
template: |
outputs: hpa: {
apiVersion: "autoscaling/v2beta2"
kind: "HorizontalPodAutoscaler"
metadata: name: context.name
spec: {
scaleTargetRef: {
apiVersion: "apps/v1"
kind: "Deployment"
name: context.name
}
minReplicas: parameter.min
maxReplicas: parameter.max
metrics: [{
type: "Resource"
resource: {
name: "cpu"
target: {
type: "Utilization"
averageUtilization: parameter.cpuUtil
}
}
}]
}
}
parameter: {
min: *1 | int
max: *6 | int
cpuUtil: *50 | int
}
status: {}
ingress-tls:
apiVersion: core.oam.dev/v1beta1
kind: TraitDefinition
metadata: {}
spec:
appliesToWorkloads:
- webservice
- worker
definitionRef:
name: ""
schematic:
cue:
template: "parameter: {\n domain: string\n http: [string]: int\n
\ annotations: [string]: string\n}\n\n// trait template can have multiple
outputs in one trait\n\n\noutputs: ingress: {\n if parameter.domain
!= _|_ {\n apiVersion: \"networking.k8s.io/v1\"\n kind: \"Ingress\"\n
\ metadata: {\n name: context.name\n annotations: {\n
\ \"cert-manager.io/cluster-issuer\": \"letsencrypt-staging\"\n
\ \"kubernetes.io/ingress.class\": \"traefik\"\n \"traefik.ingress.kubernetes.io/router.entrypoints\":
\"web,websecure\"\n \"traefik.ingress.kubernetes.io/router.tls\":
\"true\"\n for k, v in parameter.annotations {\n k:
v\n }\n \"traefik.ingress.kubernetes.io/router.middlewares\":
\"traefik-ip-whitelist-montpellier@kubernetescrd\"\n }\n\n }\n
\ spec: {\n tls: [{\n hosts: [ parameter.domain ]\n
\ secretName: parameter.domain\n }]\n rules: [{\n
\ host: parameter.domain\n http: {\n paths:
[\n for k, v in parameter.http {\n path:
k\n pathType: \"Prefix\"\n backend:
{\n service: {\n name:
context.name\n port: number: v\n }
\n }\n }\n ]\n
\ }\n }]\n }\n }\n}\n"
status: {}
labels:
apiVersion: core.oam.dev/v1beta1
kind: TraitDefinition
metadata: {}
spec:
appliesToWorkloads:
- webservice
- worker
definitionRef:
name: ""
schematic:
cue:
template: "patch: {\n\tspec: template: metadata: labels: {\n\t\tfor k,
v in parameter {\n\t\t\t\"\\(k)\": v\n\t\t}\n\t}\n}\nparameter: [string]:
string"
status: {}kubectl get applicationrevisions webserver-demo-v6 -n hello-world -o yaml
apiVersion: core.oam.dev/v1beta1
kind: ApplicationRevision
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"core.oam.dev/v1beta1","kind":"Application","metadata":{"annotations":{},"name":"webserver-demo","namespace":"hello-world"},"spec":{"components":[{"name":"hello-world","properties":{"cpu":"100m","env":[{"name":"foo","value":"bar"}],"image":"crccheck/hello-world","port":8000},"traits":[{"properties":{"annotations":{"traefik.ingress.kubernetes.io/router.middlewares":"traefik-ip-whitelist-montpellier@kubernetescrd"},"domain":"hello-world.dev.wefight-test.com","http":{"/":8000}},"type":"ingress-tls@v6"},{"properties":{"min":2},"type":"hpa"},{"properties":{"toto":"titi","tutu":"toto"},"type":"labels"},{"properties":{"toto":"titi","tutu":"toto"},"type":"annotations"}],"type":"webserver"}]}}
creationTimestamp: "2021-06-22T12:33:37Z"
generation: 1
labels:
app.oam.dev/app-revision-hash: 10e303417a684620
app.oam.dev/name: webserver-demo
name: webserver-demo-v6
namespace: hello-world
ownerReferences:
- apiVersion: core.oam.dev/v1beta1
controller: false
kind: Application
name: webserver-demo
uid: 08ec4dd5-091c-4b84-bd4a-8dfb6a0e1c85
resourceVersion: "288767"
uid: 230dc8ab-4850-44c3-a39b-e5478efa12b0
spec:
application:
apiVersion: core.oam.dev/v1beta1
kind: Application
metadata: {}
spec:
components:
- name: hello-world
properties:
cpu: 100m
env:
- name: foo
value: bar
image: crccheck/hello-world
port: 8000
traits:
- properties:
annotations:
traefik.ingress.kubernetes.io/router.middlewares: traefik-ip-whitelist-montpellier@kubernetescrd
domain: hello-world.dev.wefight-test.com
http:
/: 8000
type: ingress-tls@v6
- properties:
min: 2
type: hpa
- properties:
toto: titi
tutu: toto
type: labels
- properties:
toto: titi
tutu: toto
type: annotations
type: webserver
status:
rollout:
batchRollingState: ""
currentBatch: 0
lastTargetAppRevision: ""
rollingState: ""
upgradedReadyReplicas: 0
upgradedReplicas: 0
applicationConfiguration:
apiVersion: core.oam.dev/v1alpha2
kind: ApplicationConfiguration
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"core.oam.dev/v1beta1","kind":"Application","metadata":{"annotations":{},"name":"webserver-demo","namespace":"hello-world"},"spec":{"components":[{"name":"hello-world","properties":{"cpu":"100m","env":[{"name":"foo","value":"bar"}],"image":"crccheck/hello-world","port":8000},"traits":[{"properties":{"annotations":{"traefik.ingress.kubernetes.io/router.middlewares":"traefik-ip-whitelist-montpellier@kubernetescrd"},"domain":"hello-world.dev.wefight-test.com","http":{"/":8000}},"type":"ingress-tls@v6"},{"properties":{"min":2},"type":"hpa"},{"properties":{"toto":"titi","tutu":"toto"},"type":"labels"},{"properties":{"toto":"titi","tutu":"toto"},"type":"annotations"}],"type":"webserver"}]}}
labels:
app.oam.dev/name: webserver-demo
name: webserver-demo
namespace: hello-world
ownerReferences:
- apiVersion: core.oam.dev/v1beta1
controller: true
kind: Application
name: webserver-demo
uid: 08ec4dd5-091c-4b84-bd4a-8dfb6a0e1c85
spec:
components:
- revisionName: hello-world-v6
traits:
- trait:
apiVersion: v1
kind: Service
metadata:
labels:
app.oam.dev/appRevision: webserver-demo-v6
app.oam.dev/component: hello-world
app.oam.dev/name: webserver-demo
trait.oam.dev/resource: service
trait.oam.dev/type: AuxiliaryWorkload
name: hello-world
spec:
ports:
- port: 8000
targetPort: 8000
selector:
app.oam.dev/component: hello-world
- trait:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
annotations:
cert-manager.io/cluster-issuer: letsencrypt-prod
k: traefik-ip-whitelist-montpellier@kubernetescrd
kubernetes.io/ingress.class: traefik
traefik.ingress.kubernetes.io/router.entrypoints: web,websecure
traefik.ingress.kubernetes.io/router.middlewares: traefik-ip-whitelist-montpellier@kubernetescrd
traefik.ingress.kubernetes.io/router.tls: "true"
labels:
app.oam.dev/appRevision: webserver-demo-v6
app.oam.dev/component: hello-world
app.oam.dev/name: webserver-demo
trait.oam.dev/resource: ingress
trait.oam.dev/type: ingress-tls@v6
name: hello-world
spec:
rules:
- host: hello-world.dev.wefight-test.com
http:
paths:
- backend:
service:
name: hello-world
port:
number: 8000
path: /
pathType: Prefix
tls:
- hosts:
- hello-world.dev.wefight-test.com
secretName: hello-world.dev.wefight-test.com
- trait:
apiVersion: autoscaling/v2beta2
kind: HorizontalPodAutoscaler
metadata:
labels:
app.oam.dev/appRevision: webserver-demo-v6
app.oam.dev/component: hello-world
app.oam.dev/name: webserver-demo
trait.oam.dev/resource: hpa
trait.oam.dev/type: hpa
name: hello-world
spec:
maxReplicas: 6
metrics:
- resource:
name: cpu
target:
averageUtilization: 50
type: Utilization
type: Resource
minReplicas: 2
scaleTargetRef:
apiVersion: apps/v1
kind: Deployment
name: hello-world
status:
dependency: {}
observedGeneration: 0
componentDefinitions:
webserver:
apiVersion: core.oam.dev/v1beta1
kind: ComponentDefinition
metadata: {}
spec:
schematic:
cue:
template: "output: {\n apiVersion: \"apps/v1\"\n kind: \"Deployment\"\n
\ spec: {\n selector: matchLabels: {\n \"app.oam.dev/component\":
context.name\n }\n template: {\n metadata:
{\n name: context.name \n labels: {\n \"app.oam.dev/component\":
context.name\n }\n annotations: {\n \"app.oam.dev/component\":
context.name\n }\n }\n spec: {\n
\ containers: [{\n name: context.name\n
\ image: parameter.image\n\n if
parameter[\"cmd\"] != _|_ {\n command: parameter.cmd\n
\ }\n\n if parameter[\"env\"] !=
_|_ {\n env: parameter.env\n }\n\n
\ if context[\"config\"] != _|_ {\n env:
context.config\n }\n\n ports:
[{\n containerPort: parameter.port\n }]\n\n
\ if parameter[\"cpu\"] != _|_ {\n resources:
{\n limits:\n cpu:
parameter.cpu\n requests:\n cpu:
parameter.cpu\n }\n }\n }]\n
\ }\n }\n }\n}\n// an extra template\noutputs: service:
{\n apiVersion: \"v1\"\n kind: \"Service\"\n metadata:
{\n name: context.name\n }\n spec: {\n selector: {\n
\ \"app.oam.dev/component\": context.name\n }\n ports:
[\n {\n port: parameter.port\n targetPort:
parameter.port\n },\n ]\n }\n}\nparameter: {\n
\ image: string\n cmd?: [...string]\n port: *80 | int\n env?:
[...{\n name: string\n value?: string\n valueFrom?:
{\n secretKeyRef: {\n name: string\n key:
\ string\n }\n }\n }]\n cpu?: string\n}\n"
workload:
definition:
apiVersion: apps/v1
kind: Deployment
status: {}
components:
- raw:
apiVersion: core.oam.dev/v1alpha2
kind: Component
metadata:
labels:
app.oam.dev/name: webserver-demo
name: hello-world
namespace: hello-world
ownerReferences:
- apiVersion: core.oam.dev/v1beta1
controller: true
kind: Application
name: webserver-demo
uid: 08ec4dd5-091c-4b84-bd4a-8dfb6a0e1c85
spec:
workload:
apiVersion: apps/v1
kind: Deployment
metadata:
labels:
app.oam.dev/appRevision: webserver-demo-v6
app.oam.dev/component: hello-world
app.oam.dev/name: webserver-demo
workload.oam.dev/type: webserver
spec:
selector:
matchLabels:
app.oam.dev/component: hello-world
template:
metadata:
annotations:
app.oam.dev/component: hello-world
toto: titi
tutu: toto
labels:
app.oam.dev/component: hello-world
toto: titi
tutu: toto
name: hello-world
spec:
containers:
- env:
- name: foo
value: bar
image: crccheck/hello-world
name: hello-world
ports:
- containerPort: 8000
resources:
limits:
cpu: 100m
requests:
cpu: 100m
status:
observedGeneration: 0
traitDefinitions:
"":
apiVersion: core.oam.dev/v1beta1
kind: TraitDefinition
metadata: {}
spec:
appliesToWorkloads:
- webservice
- worker
definitionRef:
name: ""
schematic:
cue:
template: "parameter: {\n domain: string\n http: [string]: int\n
\ annotations: [string]: string\n}\n\n// trait template can have multiple
outputs in one trait\n\n\noutputs: ingress: {\n if parameter.domain
!= _|_ {\n apiVersion: \"networking.k8s.io/v1\"\n kind: \"Ingress\"\n
\ metadata: {\n name: context.name\n annotations: {\n
\ \"cert-manager.io/cluster-issuer\": \"letsencrypt-prod\"\n \"kubernetes.io/ingress.class\":
\"traefik\"\n \"traefik.ingress.kubernetes.io/router.entrypoints\":
\"web,websecure\"\n \"traefik.ingress.kubernetes.io/router.tls\":
\"true\"\n for k, v in parameter.annotations {\n k:
v\n }\n \"traefik.ingress.kubernetes.io/router.middlewares\":
\"traefik-ip-whitelist-montpellier@kubernetescrd\"\n }\n\n }\n
\ spec: {\n tls: [{\n hosts: [ parameter.domain ]\n
\ secretName: parameter.domain\n }]\n rules: [{\n
\ host: parameter.domain\n http: {\n paths:
[\n for k, v in parameter.http {\n path:
k\n pathType: \"Prefix\"\n backend:
{\n service: {\n name:
context.name\n port: number: v\n }
\n }\n }\n ]\n
\ }\n }]\n }\n }\n}\n"
status: {}
annotations:
apiVersion: core.oam.dev/v1beta1
kind: TraitDefinition
metadata: {}
spec:
appliesToWorkloads:
- webservice
- worker
definitionRef:
name: ""
schematic:
cue:
template: "patch: {\n\tspec: template: metadata: annotations: {\n\t\tfor
k, v in parameter {\n\t\t\t\"\\(k)\": v\n\t\t}\n\t}\n}\nparameter: [string]:
string"
status: {}
hpa:
apiVersion: core.oam.dev/v1beta1
kind: TraitDefinition
metadata: {}
spec:
appliesToWorkloads:
- deployments.apps
definitionRef:
name: ""
schematic:
cue:
template: |
outputs: hpa: {
apiVersion: "autoscaling/v2beta2"
kind: "HorizontalPodAutoscaler"
metadata: name: context.name
spec: {
scaleTargetRef: {
apiVersion: "apps/v1"
kind: "Deployment"
name: context.name
}
minReplicas: parameter.min
maxReplicas: parameter.max
metrics: [{
type: "Resource"
resource: {
name: "cpu"
target: {
type: "Utilization"
averageUtilization: parameter.cpuUtil
}
}
}]
}
}
parameter: {
min: *1 | int
max: *6 | int
cpuUtil: *50 | int
}
status: {}
labels:
apiVersion: core.oam.dev/v1beta1
kind: TraitDefinition
metadata: {}
spec:
appliesToWorkloads:
- webservice
- worker
definitionRef:
name: ""
schematic:
cue:
template: "patch: {\n\tspec: template: metadata: labels: {\n\t\tfor k,
v in parameter {\n\t\t\t\"\\(k)\": v\n\t\t}\n\t}\n}\nparameter: [string]:
string"
status: {}As you can see, webserver-demo-v3 got the annotation with the staging value, and the webserver-demo-v6 got the prod value. Thank you for your help! |
Beta Was this translation helpful? Give feedback.
-
|
I finally found where the error came from. There is the following event when applying the application with a specific revision on the ingress-tls trait: The following labels are populated when the ingress resource is created: Notice the trait.oam.dev/type: ingress-tls label. If I specify a revision for a trait, the value will be updated with the "@" value which does not seem to be allow by Kubernetes. I also noticed that there is no this issue for Components. Do you support using revision for traits? Is there a way to remove the label which is automatically injected (by kubevela i guess)? Thank you! |
Beta Was this translation helpful? Give feedback.
5 replies
-
|
Oh, yes, it's a bug, thanks for raising it. |
Beta Was this translation helpful? Give feedback.
-
|
@wonderflow You'r welcome! Is there a way to modify the label value as workaround? |
Beta Was this translation helpful? Give feedback.
-
|
This lable is automatically injected, so when the bug exists, specify a version in trait is almost not work. You can run this workflow to do upgrade:
|
Beta Was this translation helpful? Give feedback.
-
|
Thanks, it is the current workaround i use. Should i create an issue for this bug? or this conversation is enough? |
Beta Was this translation helpful? Give feedback.
-
|
@yangsoon is fixing it |
Beta Was this translation helpful? Give feedback.
Answer selected by
alexis-wefight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@wonderflow @yangsoon
I finally found where the error came from. There is the following event when applying the application with a specific revision on the ingress-tls trait:
The following labels are populated when the ingres…