Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Trust self signed certificate on private helm repo, docker registry, addon registry #4122

Closed
jinnjwu opened this issue Jun 6, 2022 · 9 comments · Fixed by #4146 or #4322
Closed
Assignees
Labels
area/addon help wanted Extra attention is needed and welcome new comers who are well skilled
Milestone

Comments

@jinnjwu
Copy link

jinnjwu commented Jun 6, 2022

Is your feature request related to a problem? Please describe.

Our internal helm docker registry , tls is self signed, when we add to kubevela, it will be failed with below error, we would like kubevela supports self signed certificate
Found 1 errors. [(download index file from https://github.systems/raw/test/helm-chats/master/addons failure Get "https://github.systems/raw/test/helm-chats/master/addons/index.yaml": x509: certificate signed by unknown authority)]

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@StevenLeiZhang
Copy link
Collaborator

possible solution: add one boolean argument for api-server, if it is true, let api-sever skip TLS check.

@wangyikewxgm
Copy link
Collaborator

wangyikewxgm commented Jun 8, 2022

possible solution: add one boolean argument for api-server, if it is true, let api-sever skip TLS check.

Since we should support this in cli side too. An option when add registry is proper. eg:

vela addon registry addon xxx --skipInsecureTls=true

@TIEDPAG
Copy link
Contributor

TIEDPAG commented Jun 8, 2022

Or whether it can support private ca at the same time. cli use

vela addon registry add vela-private --caCert ${userDir}/ca.crt

@StevenLeiZhang
Copy link
Collaborator

Or whether it can support private ca at the same time. cli use

vela addon registry add vela-private --caCert ${userDir}/ca.crt
  1. vela may connect multiple private TLS endpoints, if that user need specify ca.crt for every endpoint.
  2. the private TLS endpoint may be setup by another team, so vela admin does not have ca.crt

@StevenLeiZhang
Copy link
Collaborator

possible solution: add one boolean argument for api-server, if it is true, let api-sever skip TLS check.

Since we should support this in cli side too. An option when add registry is proper. eg:

vela addon registry addon xxx --skipInsecureTls=true

Yes

@TIEDPAG
Copy link
Contributor

TIEDPAG commented Jun 9, 2022

possible solution: add one boolean argument for api-server, if it is true, let api-sever skip TLS check.

Since we should support this in cli side too. An option when add registry is proper. eg:

vela addon registry addon xxx --skipInsecureTls=true

Yes

I understand the reason for this support, can you assign this issue to me

@wonderflow
Copy link
Collaborator

@TIEDPAG Assigned , you can also assign by yourself with the comment /assign

@wangyikewxgm wangyikewxgm added help wanted Extra attention is needed and welcome new comers who are well skilled and removed good first issue Good for newcomers labels Jun 9, 2022
TIEDPAG pushed a commit to TIEDPAG/kubevela that referenced this issue Jun 10, 2022
@barnettZQG barnettZQG added this to the KubeVela-v1.5 milestone Jun 14, 2022
TIEDPAG pushed a commit to TIEDPAG/kubevela that referenced this issue Jun 15, 2022
Signed-off-by: damianqin <damianqin@tiedpag.club>
TIEDPAG pushed a commit to TIEDPAG/kubevela that referenced this issue Jun 16, 2022
Signed-off-by: damianqin <damianqin@tiedpag.club>
@charlie0129
Copy link
Member

  1. vela may connect multiple private TLS endpoints, if that user need specify ca.crt for every endpoint.

What about storing the certificate in the registry config? Just like username and password does. When the user wants to access the registry, the certificate is automatically loaded.

@wonderflow
Copy link
Collaborator

  1. vela may connect multiple private TLS endpoints, if that user need specify ca.crt for every endpoint.

What about storing the certificate in the registry config? Just like username and password does. When the user wants to access the registry, the certificate is automatically loaded.

Yes. That should be good experience

TIEDPAG pushed a commit to TIEDPAG/kubevela that referenced this issue Jul 15, 2022
Signed-off-by: damianqin <damianqin@tiedpag.club>
TIEDPAG pushed a commit to TIEDPAG/kubevela that referenced this issue Jul 15, 2022
Signed-off-by: damianqin <damianqin@tiedpag.club>
wonderflow added a commit that referenced this issue Jul 19, 2022
* Feat: support addon helm repo skip tls verify (#4122)

Signed-off-by: damianqin <damianqin@tiedpag.club>

* Fix: mv http server to BeforeSuite

Signed-off-by: damianqin <damianqin@tiedpag.club>

* Fix: fix ci error

Signed-off-by: damianqin <damianqin@tiedpag.club>

* Fix: fix merge

Signed-off-by: damianqin <damianqin@tiedpag.club>

* Feat: support addon helm repo skip tls verify (#4122)

Signed-off-by: damianqin <damianqin@tiedpag.club>

* Fix: mv http server to BeforeSuite

Signed-off-by: damianqin <damianqin@tiedpag.club>

* Fix: fix ci error

Signed-off-by: damianqin <damianqin@tiedpag.club>

* Fix: fix ci

Signed-off-by: damianqin <damianqin@tiedpag.club>

Co-authored-by: damianqin <damianqin@tiedpag.club>
Co-authored-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addon help wanted Extra attention is needed and welcome new comers who are well skilled
Projects
None yet
7 participants