Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to display access endpoints for a normal chart #4163

Closed
zzxwill opened this issue Jun 13, 2022 · 2 comments · Fixed by #4166
Closed

No need to display access endpoints for a normal chart #4163

zzxwill opened this issue Jun 13, 2022 · 2 comments · Fixed by #4166
Assignees
Labels
Milestone

Comments

@zzxwill
Copy link
Collaborator

zzxwill commented Jun 13, 2022

Describe the bug

Locally installed a Chart crossplane, and there is access endpoints shown after the installation, which is not necessary as we don't access it from anywhere.

➜  addons git:(crossplane) ✗ vela addon enable ./crossplane
enable addon by local dir: ./crossplane
I0613 16:30:53.057039    4400 apply.go:107] "creating object" name="addon-secret-crossplane" resource="/v1, Kind=Secret"
Addon: crossplane enabled Successfully.
Please access the crossplane from the following endpoints:
I0613 16:31:49.468440    4400 utils.go:156] find cluster gateway service vela-system/kubevela-cluster-gateway-service:9443
+---------+-----------+--------------------------+----------+
| CLUSTER | COMPONENT | REF(KIND/NAMESPACE/NAME) | ENDPOINT |
+---------+-----------+--------------------------+----------+
+---------+-----------+--------------------------+----------+

To Reproduce

  1. Apply the addon

In file crossplane/resources/crossplane.cue, it shows as below.

output: {
	type: "helm"
	properties: {
		repoType: "helm"
		url:      "https://charts.crossplane.io/stable"
		chart:    "crossplane"
		version:  "1.8.1"
	}
}
  1. vela addon enable ./crossplane

Expected behavior

Screenshots

KubeVela Version

Cluster information

Additional context

@wonderflow
Copy link
Collaborator

Yes, we can omit the table if the results is empty.

@wonderflow wonderflow added the good first issue Good for newcomers label Jun 13, 2022
@charlie0129
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants