-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: skip endpoint table if no endpoints are found in addons #4166
Conversation
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #4166 +/- ##
===========================================
+ Coverage 44.74% 60.47% +15.73%
===========================================
Files 328 330 +2
Lines 31578 31911 +333
===========================================
+ Hits 14128 19298 +5170
+ Misses 15188 10104 -5084
- Partials 2262 2509 +247
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.4
git worktree add -d .worktree/backport-4166-to-release-1.4 origin/release-1.4
cd .worktree/backport-4166-to-release-1.4
git checkout -b backport-4166-to-release-1.4
ancref=$(git merge-base 0c190ef32948561b577ccb0ca8432aee74bcfc80 f9d607f92f716026160a2b24c49a2619cf77aa05)
git cherry-pick -x $ancref..f9d607f92f716026160a2b24c49a2619cf77aa05 |
Signed-off-by: Charlie Chiang charlie_c_0129@outlook.com
Description of your changes
Please refer to #4163. Changes are exactly the same as what is described in that issue. Addons with no endpoints will skip the table, otherwise it is not affected.
Fixes #4163
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer