Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: skip endpoint table if no endpoints are found in addons #4166

Merged
merged 4 commits into from Jun 20, 2022

Conversation

charlie0129
Copy link
Member

@charlie0129 charlie0129 commented Jun 13, 2022

Signed-off-by: Charlie Chiang charlie_c_0129@outlook.com

Description of your changes

Please refer to #4163. Changes are exactly the same as what is described in that issue. Addons with no endpoints will skip the table, otherwise it is not affected.

Fixes #4163

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
@charlie0129 charlie0129 marked this pull request as ready for review June 13, 2022 14:35
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #4166 (f9d607f) into master (8767309) will increase coverage by 15.73%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #4166       +/-   ##
===========================================
+ Coverage   44.74%   60.47%   +15.73%     
===========================================
  Files         328      330        +2     
  Lines       31578    31911      +333     
===========================================
+ Hits        14128    19298     +5170     
+ Misses      15188    10104     -5084     
- Partials     2262     2509      +247     
Flag Coverage Δ
apiserver-unittests 35.39% <ø> (-0.12%) ⬇️
core-unittests 55.02% <ø> (?)
e2e-multicluster-test 20.01% <ø> (-0.03%) ⬇️
e2e-rollout-tests 22.31% <ø> (-0.01%) ⬇️
e2etests 29.35% <ø> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/domain/service/velaql.go 54.54% <0.00%> (-13.64%) ⬇️
pkg/resourcekeeper/componentrevision.go 64.28% <0.00%> (-7.15%) ⬇️
...kg/apiserver/interfaces/api/assembler/v1/do2dto.go 58.86% <0.00%> (-6.39%) ⬇️
pkg/workflow/hooks/data_passing.go 45.45% <0.00%> (-4.55%) ⬇️
pkg/apiserver/domain/service/addon.go 58.69% <0.00%> (-0.73%) ⬇️
apis/types/capability.go 0.00% <0.00%> (ø)
pkg/webhook/common/rollout/rollout_plan.go 36.84% <0.00%> (ø)
cmd/core/main.go 9.54% <0.00%> (ø)
pkg/cue/process/handle.go 63.63% <0.00%> (+0.82%) ⬆️
...ntroller/common/rollout/rollout_plan_controller.go 1.53% <0.00%> (+1.53%) ⬆️
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8767309...f9d607f. Read the comment docs.

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Copy link
Collaborator

@wangyikewxgm wangyikewxgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonderflow wonderflow added the backport release-1.4 add this label will automatically backport this PR to release-1.4 branch label Jun 20, 2022
@wonderflow wonderflow changed the title Feat: skip endpoint table if no endpoints are found in addons Fix: skip endpoint table if no endpoints are found in addons Jun 20, 2022
@Somefive Somefive merged commit e81d8dd into kubevela:master Jun 20, 2022
@github-actions
Copy link

Backport failed for release-1.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.4
git worktree add -d .worktree/backport-4166-to-release-1.4 origin/release-1.4
cd .worktree/backport-4166-to-release-1.4
git checkout -b backport-4166-to-release-1.4
ancref=$(git merge-base 0c190ef32948561b577ccb0ca8432aee74bcfc80 f9d607f92f716026160a2b24c49a2619cf77aa05)
git cherry-pick -x $ancref..f9d607f92f716026160a2b24c49a2619cf77aa05

@wonderflow wonderflow removed the backport release-1.4 add this label will automatically backport this PR to release-1.4 branch label Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No need to display access endpoints for a normal chart
4 participants