Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vela addon upgrade missing the history args #4311

Closed
barnettZQG opened this issue Jul 2, 2022 · 4 comments · Fixed by #4388
Closed

vela addon upgrade missing the history args #4311

barnettZQG opened this issue Jul 2, 2022 · 4 comments · Fixed by #4388
Assignees
Labels
area/addon help wanted Extra attention is needed and welcome new comers who are well skilled
Milestone

Comments

@barnettZQG
Copy link
Collaborator

Describe the bug

The different vela addon upgrade with vela addon enable should keep the history args and support override it with new args. But, currently, it is not.

To Reproduce

  1. vela addon enable velaux --version=v1.4.2 repo=acr.kubevela.net
  2. vela addon upgrade velaux --version=v1.4.5

The repo=acr.kubevela.net will be missing

KubeVela Version

1.4.5

@barnettZQG barnettZQG added type/bug Something isn't working area/addon labels Jul 2, 2022
@charlie0129
Copy link
Member

BTW, the usage about adding args like repo=acr.kubevela.net is not documented in command help text (only on web doc). The user have no way of knowing this only using CLI. We should add it to CLI command help.

@wonderflow
Copy link
Collaborator

BTW, the usage about adding args like repo=acr.kubevela.net is not documented in command help text (only on web doc). The user have no way of knowing this only using CLI. We should add it to CLI command help.

Yes, definitely. The command help text should be the best document.

@barnettZQG barnettZQG added help wanted Extra attention is needed and welcome new comers who are well skilled and removed type/bug Something isn't working labels Jul 5, 2022
@barnettZQG barnettZQG added this to the KubeVela-v1.5 milestone Jul 7, 2022
@StevenLeiZhang
Copy link
Collaborator

BTW, the usage about adding args like repo=acr.kubevela.net is not documented in command help text (only on web doc). The user have no way of knowing this only using CLI. We should add it to CLI command help.

because it is argument of VelaUX addon, not vela cmd

@charlie0129
Copy link
Member

because it is argument of VelaUX addon, not vela cmd

Yes, you are right. But what I mean is that the user don't know he can input parameters here. Because it is not documented. This has been fixed in this pr #4346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addon help wanted Extra attention is needed and welcome new comers who are well skilled
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants