-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: vela addon upgrade missing the history args #4388
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4388 +/- ##
==========================================
+ Coverage 61.45% 61.50% +0.05%
==========================================
Files 347 347
Lines 34260 34281 +21
==========================================
+ Hits 21054 21086 +32
+ Misses 10454 10444 -10
+ Partials 2752 2751 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6d557ad
to
15bda46
Compare
5015e73
to
7bd7566
Compare
7bd7566
to
c2be506
Compare
Great, please let the user know that the arguments will be merged in the command help text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job
Signed-off-by: StevenLeiZhang <zhangleiic@163.com>
c2be506
to
276984a
Compare
Done |
Signed-off-by: StevenLeiZhang zhangleiic@163.com
Description of your changes
Fixes #4311
How to fix it:
Merge legacy parameters and new input parameters.
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer