align workload/trait definition schema with v0.2.2 spec #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1117 +/- ##
==========================================
- Coverage 53.74% 52.04% -1.70%
==========================================
Files 70 72 +2
Lines 5975 6244 +269
==========================================
+ Hits 3211 3250 +39
- Misses 2404 2634 +230
Partials 360 360
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
wonderflow
requested review from
resouer and
ryanzhang-oss
and removed request for
resouer
| // Schematic defines the encapsulation of this capability(workload/trait/scope), | ||
| // the encapsulation can be defined in different ways, e.g. CUE/HCL(terraform)/KUBE(K8s Object)/HELM, etc... | ||
| type Schematic struct { | ||
| CUE *CUE `json:"cue,omitempty"` |
There was a problem hiding this comment.
There are some discussions about using a plug-in model instead of hardcode each schematic
There was a problem hiding this comment.
The agreement is we keep it as is until another new schematic type besides CUE, Helm, Kube, ARM comes in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #976
align with oam-dev/spec#443