Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import inner package in the format of third party package path and split test cases #1412

Merged
merged 3 commits into from
Apr 2, 2021

Conversation

leejanee
Copy link
Member

@leejanee leejanee commented Apr 2, 2021

split test cases for third party package
and,Fix the bug that will cause the wrong package check result

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #1412 (88cc9fb) into master (f47ca0f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
- Coverage   54.79%   54.77%   -0.02%     
==========================================
  Files          76       76              
  Lines        7304     7306       +2     
==========================================
  Hits         4002     4002              
- Misses       2818     2819       +1     
- Partials      484      485       +1     
Flag Coverage Δ
unittests 54.77% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/dsl/definition/package.go 85.55% <100.00%> (+0.16%) ⬆️
...plicationconfiguration/applicationconfiguration.go 83.69% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f47ca0f...88cc9fb. Read the comment docs.

@wonderflow wonderflow changed the title Split test cases for third party package fix import inner package in the format of third party package path and split test cases Apr 2, 2021
@wonderflow wonderflow merged commit 4b25ed4 into kubevela:master Apr 2, 2021
@leejanee leejanee deleted the pr1411 branch August 11, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants