Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug: strategyUnify not work with close call #1430

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

leejanee
Copy link
Member

@leejanee leejanee commented Apr 8, 2021

Fix the bug that strategyUnify not work with close call

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #1430 (021b2e9) into master (473164e) will increase coverage by 0.06%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1430      +/-   ##
==========================================
+ Coverage   51.50%   51.57%   +0.06%     
==========================================
  Files          81       81              
  Lines        8013     8018       +5     
==========================================
+ Hits         4127     4135       +8     
+ Misses       3386     3384       -2     
+ Partials      500      499       -1     
Flag Coverage Δ
unittests 51.57% <88.88%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/dsl/model/sets/utils.go 76.05% <88.88%> (+0.29%) ⬆️
...aits/traitdefinition/traitdefinition_controller.go 77.14% <0.00%> (+11.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 473164e...021b2e9. Read the comment docs.

@wonderflow wonderflow merged commit a446aab into kubevela:master Apr 8, 2021
@wonderflow wonderflow deleted the fixbug-patch branch April 8, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants