Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add apply raw built in workflow steps #2420

Merged
merged 4 commits into from Oct 9, 2021

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Oct 8, 2021

Description of your changes

Add apply raw built in workflow steps

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

/cc @wonderflow

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #2420 (2341bf0) into master (46e22cc) will increase coverage by 3.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2420      +/-   ##
==========================================
+ Coverage   57.93%   61.23%   +3.30%     
==========================================
  Files         160      160              
  Lines       16997    16997              
==========================================
+ Hits         9847    10408     +561     
+ Misses       6053     5477     -576     
- Partials     1097     1112      +15     
Flag Coverage Δ
e2e-multicluster-test 19.92% <ø> (+0.09%) ⬆️
e2e-rollout-tests 31.29% <ø> (?)
e2etests 37.26% <ø> (+0.08%) ⬆️
unittests 55.55% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tepdefinition/workflowstepdefinition_controller.go 59.74% <0.00%> (-6.50%) ⬇️
...am.dev/v1alpha2/applicationconfiguration/render.go 87.39% <0.00%> (-0.82%) ⬇️
apis/core.oam.dev/v1beta1/zz_generated.deepcopy.go 42.26% <0.00%> (+0.26%) ⬆️
pkg/oam/util/helper.go 73.90% <0.00%> (+0.73%) ⬆️
...ller/core.oam.dev/v1alpha2/application/revision.go 73.48% <0.00%> (+0.75%) ⬆️
pkg/appfile/template.go 56.72% <0.00%> (+0.84%) ⬆️
...m.dev/v1alpha1/envbinding/envbinding_controller.go 72.89% <0.00%> (+1.20%) ⬆️
....oam.dev/v1alpha2/application/dispatch/dispatch.go 77.16% <0.00%> (+1.23%) ⬆️
apis/core.oam.dev/common/zz_generated.deepcopy.go 36.77% <0.00%> (+1.29%) ⬆️
pkg/controller/utils/utils.go 45.61% <0.00%> (+1.75%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46e22cc...2341bf0. Read the comment docs.

@wonderflow
Copy link
Collaborator

please also add docs

@github-actions
Copy link

github-actions bot commented Oct 9, 2021

Successfully created backport PR #2424 for release-1.1.

@FogDong FogDong deleted the feat-applyraw branch October 26, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants