New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Closure Bug In newValue #2437
Conversation
} | ||
if err := stdlib.AddImportsFor(builder, tagTempl); err != nil { | ||
if err := stdlib.AddImportsFor(inst, tagTempl); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add a test case for this bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个改动前后是等效的,但确实是写法有问题,需要修复
Codecov Report
@@ Coverage Diff @@
## master #2437 +/- ##
==========================================
- Coverage 61.01% 51.81% -9.20%
==========================================
Files 160 224 +64
Lines 16997 23291 +6294
==========================================
+ Hits 10370 12068 +1698
- Misses 5504 9804 +4300
- Partials 1123 1419 +296
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Successfully created backport PR #2452 for |
Description of your changes
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer