Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Closure Bug In newValue #2437

Merged
merged 3 commits into from Oct 12, 2021
Merged

Fix: Closure Bug In newValue #2437

merged 3 commits into from Oct 12, 2021

Conversation

leejanee
Copy link
Member

@leejanee leejanee commented Oct 11, 2021

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

}
if err := stdlib.AddImportsFor(builder, tagTempl); err != nil {
if err := stdlib.AddImportsFor(inst, tagTempl); err != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a test case for this bug

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改动前后是等效的,但确实是写法有问题,需要修复

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #2437 (f9bfbc0) into master (f06980c) will decrease coverage by 9.19%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2437      +/-   ##
==========================================
- Coverage   61.01%   51.81%   -9.20%     
==========================================
  Files         160      224      +64     
  Lines       16997    23291    +6294     
==========================================
+ Hits        10370    12068    +1698     
- Misses       5504     9804    +4300     
- Partials     1123     1419     +296     
Flag Coverage Δ
apiserver-unittests 22.26% <ø> (?)
core-unittests 46.56% <50.00%> (?)
e2e-multicluster-test 19.88% <50.00%> (+0.22%) ⬆️
e2e-rollout-tests 31.15% <25.00%> (-0.05%) ⬇️
e2etests 37.16% <50.00%> (-0.02%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cue/model/value/value.go 84.75% <50.00%> (+0.74%) ⬆️
pkg/cue/model/sets/walk.go 82.00% <100.00%> (+0.75%) ⬆️
...ollout/workloads/statefulset_rollout_controller.go 89.28% <0.00%> (-3.42%) ⬇️
...n/rollout/workloads/cloneset_rollout_controller.go 85.88% <0.00%> (-2.87%) ⬇️
...es/policydefinition/policydefinition_controller.go 60.25% <0.00%> (-2.57%) ⬇️
...troller/core.oam.dev/v1alpha1/envbinding/engine.go 73.09% <0.00%> (-1.17%) ⬇️
pkg/builtin/kind/client.go 27.69% <0.00%> (-0.88%) ⬇️
...dev/v1alpha2/applicationconfiguration/component.go 58.26% <0.00%> (-0.79%) ⬇️
cmd/core/main.go 10.74% <0.00%> (-0.11%) ⬇️
references/cli/help.go 0.00% <0.00%> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06980c...f9bfbc0. Read the comment docs.

@github-actions
Copy link

Successfully created backport PR #2452 for release-1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants