Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update ingress class #2445

Merged
merged 1 commit into from Oct 11, 2021
Merged

Fix: update ingress class #2445

merged 1 commit into from Oct 11, 2021

Conversation

Somefive
Copy link
Collaborator

Description of your changes

Add ingress class annotation for ingress trait. Fixes #2439.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #2445 (77e1b82) into master (472ed3a) will increase coverage by 5.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2445      +/-   ##
==========================================
+ Coverage   55.87%   61.07%   +5.19%     
==========================================
  Files         160      160              
  Lines       17014    17020       +6     
==========================================
+ Hits         9507    10395     +888     
+ Misses       6409     5503     -906     
- Partials     1098     1122      +24     
Flag Coverage Δ
e2e-multicluster-test 19.87% <ø> (-0.03%) ⬇️
e2e-rollout-tests 31.21% <ø> (+0.02%) ⬆️
e2etests 37.21% <ø> (?)
unittests 55.39% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...m.dev/v1alpha1/envbinding/envbinding_controller.go 69.27% <0.00%> (-3.62%) ⬇️
...ollout/workloads/statefulset_rollout_controller.go 89.28% <0.00%> (-3.42%) ⬇️
...n/rollout/workloads/cloneset_rollout_controller.go 85.88% <0.00%> (-2.87%) ⬇️
...dev/v1alpha2/applicationconfiguration/component.go 59.05% <0.00%> (+0.78%) ⬆️
pkg/cue/definition/template.go 59.91% <0.00%> (+0.86%) ⬆️
apis/standard.oam.dev/v1alpha1/rollout_state.go 72.53% <0.00%> (+1.03%) ⬆️
...plicationconfiguration/applicationconfiguration.go 88.58% <0.00%> (+1.20%) ⬆️
...troller/core.oam.dev/v1alpha2/application/apply.go 78.32% <0.00%> (+1.97%) ⬆️
apis/core.oam.dev/v1alpha2/conversion.go 44.44% <0.00%> (+2.22%) ⬆️
...am.dev/v1alpha2/applicationconfiguration/render.go 88.21% <0.00%> (+2.23%) ⬆️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 472ed3a...77e1b82. Read the comment docs.

Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@wonderflow wonderflow merged commit 2e20f48 into kubevela:master Oct 11, 2021
@github-actions
Copy link

Successfully created backport PR #2447 for release-1.1.

@Somefive Somefive deleted the fix_ingress branch November 24, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

first-vela-app cannot bind load balancer in AKS with default nginx ingress controller
2 participants