Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add export config and secret def #2484

Merged
merged 3 commits into from Oct 15, 2021

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Oct 14, 2021

Description of your changes

Fixes #405

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

/cc @wonderflow

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #2484 (1e92d64) into master (7ef8005) will decrease coverage by 0.28%.
The diff coverage is 18.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2484      +/-   ##
==========================================
- Coverage   52.14%   51.85%   -0.29%     
==========================================
  Files         224      221       -3     
  Lines       23266    23024     -242     
==========================================
- Hits        12131    11939     -192     
+ Misses       9716     9673      -43     
+ Partials     1419     1412       -7     
Flag Coverage Δ
apiserver-unittests 25.53% <ø> (ø)
core-unittests 46.56% <18.91%> (-0.04%) ⬇️
e2e-multicluster-test 21.06% <ø> (+0.93%) ⬆️
e2e-rollout-tests 31.19% <ø> (-0.13%) ⬇️
e2etests 37.02% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
references/cli/addon.go 6.55% <18.91%> (+5.64%) ⬆️
apis/core.oam.dev/v1beta1/policy_definition.go 0.00% <0.00%> (-50.00%) ⬇️
.../core.oam.dev/v1beta1/componentdefinition_types.go 50.00% <0.00%> (-50.00%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 65.26% <0.00%> (-10.53%) ⬇️
...v/v1alpha2/componentdefinition/mutating_handler.go 74.00% <0.00%> (-10.00%) ⬇️
...es/policydefinition/policydefinition_controller.go 60.25% <0.00%> (-6.42%) ⬇️
...m.dev/v1alpha1/envbinding/envbinding_controller.go 69.27% <0.00%> (-6.03%) ⬇️
...ponentdefinition/componentdefinition_controller.go 80.00% <0.00%> (-5.56%) ⬇️
pkg/controller/utils/utils.go 40.19% <0.00%> (-5.42%) ⬇️
pkg/controller/core.oam.dev/v1alpha2/setup.go 36.00% <0.00%> (-2.47%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a8b0c...1e92d64. Read the comment docs.

type: export-config
inputs:
- from: status
parameterKey: data.serverstatus
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个用法其实挺难理解的,这里要在 export2config 的文档里给用户说明2点:

  1. data. 是固定的前缀。
  2. 后面的 serverstatus 是自动命名的。

@FogDong
Copy link
Member Author

FogDong commented Oct 15, 2021

Test label trigger:

/backport 1.1

1 similar comment
@FogDong
Copy link
Member Author

FogDong commented Oct 15, 2021

Test label trigger:

/backport 1.1

@FogDong FogDong merged commit e2ce40a into kubevela:master Oct 15, 2021
@FogDong FogDong deleted the feat-export-config branch October 15, 2021 07:25
@github-actions
Copy link

Successfully created backport PR #2498 for release-1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WorkflowStep Request] dynamically write fields of workload status into configmap/secret
2 participants