Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove initializer #2491

Merged
merged 1 commit into from Oct 15, 2021
Merged

Conversation

chivalryq
Copy link
Member

Description of your changes

Fixes #2347

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #2491 (bc5c5c6) into master (1801471) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2491      +/-   ##
==========================================
- Coverage   52.12%   51.90%   -0.23%     
==========================================
  Files         224      221       -3     
  Lines       23293    23024     -269     
==========================================
- Hits        12142    11950     -192     
+ Misses       9726     9665      -61     
+ Partials     1425     1409      -16     
Flag Coverage Δ
apiserver-unittests 25.53% <ø> (ø)
core-unittests 46.63% <ø> (+0.03%) ⬆️
e2e-multicluster-test 21.06% <0.00%> (+0.12%) ⬆️
e2e-rollout-tests 31.28% <0.00%> (+0.42%) ⬆️
e2etests 37.14% <0.00%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/core.oam.dev/v1beta1/register.go 92.85% <ø> (-0.48%) ⬇️
apis/core.oam.dev/v1beta1/zz_generated.deepcopy.go 42.64% <ø> (+0.01%) ⬆️
pkg/controller/core.oam.dev/v1alpha2/setup.go 36.00% <0.00%> (-2.47%) ⬇️
pkg/controller/utils/utils.go 40.19% <ø> (-4.55%) ⬇️
pkg/webhook/core.oam.dev/register.go 48.38% <ø> (-0.10%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 70.52% <0.00%> (-7.37%) ⬇️
...ponentdefinition/componentdefinition_controller.go 80.00% <0.00%> (-5.56%) ⬇️
...ler/core.oam.dev/v1alpha2/application/generator.go 77.35% <0.00%> (-1.89%) ⬇️
...ller/core.oam.dev/v1alpha2/application/revision.go 72.72% <0.00%> (-0.76%) ⬇️
pkg/oam/util/helper.go 72.92% <0.00%> (-0.49%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1801471...bc5c5c6. Read the comment docs.

Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Copy link
Collaborator

@yangsoon yangsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wonderflow wonderflow merged commit 49bfeee into kubevela:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] deprecate initilizer and use application instead
3 participants