Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add alibaba cloud redis definition #2507

Merged
merged 1 commit into from Nov 16, 2021

Conversation

chivalryq
Copy link
Member

@chivalryq chivalryq commented Oct 18, 2021

Description of your changes

  1. add alibaba cloud redis definition

related #1770

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #2507 (2a4cb17) into master (1801471) will increase coverage by 9.39%.
The diff coverage is n/a.

❗ Current head 2a4cb17 differs from pull request most recent head f073edc. Consider uploading reports for the commit f073edc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2507      +/-   ##
==========================================
+ Coverage   52.12%   61.51%   +9.39%     
==========================================
  Files         224      158      -66     
  Lines       23293    16806    -6487     
==========================================
- Hits        12142    10339    -1803     
+ Misses       9726     5355    -4371     
+ Partials     1425     1112     -313     
Flag Coverage Δ
apiserver-unittests ?
core-unittests 55.10% <ø> (+8.50%) ⬆️
e2e-multicluster-test 23.25% <ø> (+2.31%) ⬆️
e2e-rollout-tests 32.19% <ø> (+1.34%) ⬆️
e2etests 37.90% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pis/core.oam.dev/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (-37.23%) ⬇️
pkg/utils/common/common.go 45.09% <0.00%> (-13.85%) ⬇️
pkg/multicluster/utils.go 53.70% <0.00%> (-9.26%) ⬇️
pkg/utils/apply/apply.go 84.69% <0.00%> (-7.50%) ⬇️
pkg/workflow/providers/kube/handle.go 62.50% <0.00%> (-6.13%) ⬇️
pkg/workflow/providers/oam/apply.go 71.42% <0.00%> (-5.85%) ⬇️
pkg/controller/utils/utils.go 40.19% <0.00%> (-4.55%) ⬇️
pkg/controller/core.oam.dev/v1alpha2/setup.go 36.00% <0.00%> (-2.47%) ⬇️
pkg/cue/process/handle.go 76.78% <0.00%> (-2.12%) ⬇️
...dev/v1alpha2/application/application_controller.go 71.36% <0.00%> (-1.71%) ⬇️
... and 115 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1801471...f073edc. Read the comment docs.

@@ -16,7 +16,7 @@ data:
apiVersion: v1
kind: Secret
metadata:
name: alibaba-provider-secret
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他 Provider 都 follow 了目前的命名规则,建议保持现状。

@zzxwill
Copy link
Collaborator

zzxwill commented Oct 18, 2021

Please store .tf and Configuration in the repo https://github.com/oam-dev/terraform-controller.

@zzxwill zzxwill closed this Oct 18, 2021
@zzxwill zzxwill reopened this Oct 18, 2021
@zzxwill
Copy link
Collaborator

zzxwill commented Oct 18, 2021

Please store .tf and Configuration in the repo https://github.com/oam-dev/terraform-controller.

Please also add this cloud resource in https://kubevela.io.

@@ -16,7 +16,7 @@ data:
apiVersion: v1
kind: Secret
metadata:
name: alibaba-provider-secret
name: alibaba-account-creds
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creds 是什么?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

credentials的缩写,这个地方不暴露给用户,保持一致就可以。

@@ -13,7 +13,7 @@ spec:
apiVersion: v1
kind: Secret
metadata:
name: alibaba-provider-secret
name: alibaba-account-creds
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provider should not be touched for adding another cloud resource.

@wonderflow wonderflow merged commit 061c061 into kubevela:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants