New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add alibaba cloud redis definition #2507
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2507 +/- ##
==========================================
+ Coverage 52.12% 61.51% +9.39%
==========================================
Files 224 158 -66
Lines 23293 16806 -6487
==========================================
- Hits 12142 10339 -1803
+ Misses 9726 5355 -4371
+ Partials 1425 1112 -313
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -16,7 +16,7 @@ data: | |||
apiVersion: v1 | |||
kind: Secret | |||
metadata: | |||
name: alibaba-provider-secret |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其他 Provider 都 follow 了目前的命名规则,建议保持现状。
Please store .tf and Configuration in the repo https://github.com/oam-dev/terraform-controller. |
Please also add this cloud resource in https://kubevela.io. |
@@ -16,7 +16,7 @@ data: | |||
apiVersion: v1 | |||
kind: Secret | |||
metadata: | |||
name: alibaba-provider-secret | |||
name: alibaba-account-creds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
creds 是什么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
credentials的缩写,这个地方不暴露给用户,保持一致就可以。
@@ -13,7 +13,7 @@ spec: | |||
apiVersion: v1 | |||
kind: Secret | |||
metadata: | |||
name: alibaba-provider-secret | |||
name: alibaba-account-creds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The provider should not be touched for adding another cloud resource.
2a4cb17
to
f073edc
Compare
Description of your changes
related #1770
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer