Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: aws/azure Terraform provider are broken #2513

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

zzxwill
Copy link
Collaborator

@zzxwill zzxwill commented Oct 18, 2021

Removed built-in aws/azure Terraform providers, and fix azure
mariadb definition issue.

Fix #2475

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #2513 (db98e07) into master (d82f8e3) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2513      +/-   ##
==========================================
+ Coverage   61.51%   61.71%   +0.20%     
==========================================
  Files         180      180              
  Lines       17432    17432              
==========================================
+ Hits        10723    10759      +36     
+ Misses       5529     5505      -24     
+ Partials     1180     1168      -12     
Flag Coverage Δ
apiserver-unittests 11.33% <ø> (ø)
core-unittests 55.59% <ø> (+0.04%) ⬆️
e2e-multicluster-test 21.16% <ø> (+0.08%) ⬆️
e2e-rollout-tests 31.13% <ø> (+0.01%) ⬆️
e2etests 37.10% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/standard.oam.dev/v1alpha1/rollout_state.go 72.53% <0.00%> (-1.04%) ⬇️
...es/policydefinition/policydefinition_controller.go 66.66% <0.00%> (ø)
pkg/oam/util/helper.go 73.41% <0.00%> (+0.48%) ⬆️
pkg/controller/utils/capability.go 80.58% <0.00%> (+0.73%) ⬆️
...troller/core.oam.dev/v1alpha2/application/apply.go 79.31% <0.00%> (+0.98%) ⬆️
....oam.dev/v1alpha2/application/dispatch/dispatch.go 77.32% <0.00%> (+1.16%) ⬆️
...g/controller/core.oam.dev/v1alpha2/core/revison.go 73.91% <0.00%> (+2.17%) ⬆️
...m.dev/v1alpha1/envbinding/envbinding_controller.go 75.30% <0.00%> (+3.61%) ⬆️
...dev/v1alpha2/application/application_controller.go 75.00% <0.00%> (+4.32%) ⬆️
...tepdefinition/workflowstepdefinition_controller.go 66.23% <0.00%> (+6.49%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d82f8e3...db98e07. Read the comment docs.

Removed built-in aws/azure Terraform providers, and fix azure
mariadb definition issue.

Fix kubevela#2475
@wonderflow wonderflow merged commit d1e814e into kubevela:master Oct 19, 2021
@github-actions
Copy link

Backport failed for release-1.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.1
git worktree add -d .worktree/backport-2513-to-release-1.1 origin/release-1.1
cd .worktree/backport-2513-to-release-1.1
git checkout -b backport-2513-to-release-1.1
ancref=$(git merge-base d82f8e3cc6ee07707683d4f4f7217b6ddf7ad66c db98e07bdf00166428876809b82db9bc5ed0081d)
git cherry-pick -x $ancref..db98e07bdf00166428876809b82db9bc5ed0081d

@zzxwill zzxwill deleted the azure-issue branch November 11, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform Controller Installs Corrupted Azure Provider
2 participants