Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not update resource if render hash equal. #2522

Merged
merged 2 commits into from Oct 19, 2021

Conversation

leejanee
Copy link
Member

@leejanee leejanee commented Oct 19, 2021

Description of your changes

Fixes #2416 #2502

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #2522 (6310ed8) into master (9fea82f) will decrease coverage by 0.15%.
The diff coverage is 82.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2522      +/-   ##
==========================================
- Coverage   61.82%   61.66%   -0.16%     
==========================================
  Files         182      182              
  Lines       17538    17575      +37     
==========================================
- Hits        10842    10837       -5     
- Misses       5518     5546      +28     
- Partials     1178     1192      +14     
Flag Coverage Δ
apiserver-unittests 11.32% <0.00%> (-0.01%) ⬇️
core-unittests 55.51% <44.68%> (-0.28%) ⬇️
e2e-multicluster-test 21.33% <51.06%> (+0.19%) ⬆️
e2e-rollout-tests 31.50% <59.57%> (+0.14%) ⬆️
e2etests 36.95% <72.34%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/apply/apply.go 86.73% <80.48%> (-5.46%) ⬇️
....oam.dev/v1alpha2/application/dispatch/dispatch.go 77.32% <100.00%> (ø)
...plicationconfiguration/applicationconfiguration.go 88.58% <100.00%> (ø)
pkg/cue/model/sets/utils.go 78.72% <100.00%> (+0.34%) ⬆️
...aits/traitdefinition/traitdefinition_controller.go 65.26% <0.00%> (-17.90%) ⬇️
...ponentdefinition/componentdefinition_controller.go 80.00% <0.00%> (-5.56%) ⬇️
...m.dev/v1alpha1/envbinding/envbinding_controller.go 72.89% <0.00%> (-2.41%) ⬇️
pkg/appfile/parser.go 66.96% <0.00%> (-1.77%) ⬇️
apis/standard.oam.dev/v1alpha1/rollout_state.go 71.50% <0.00%> (-1.04%) ⬇️
pkg/appfile/template.go 55.88% <0.00%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fea82f...6310ed8. Read the comment docs.

@wonderflow wonderflow merged commit 99f1743 into kubevela:master Oct 19, 2021
@github-actions
Copy link

Backport failed for release-1.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.1
git worktree add -d .worktree/backport-2522-to-release-1.1 origin/release-1.1
cd .worktree/backport-2522-to-release-1.1
git checkout -b backport-2522-to-release-1.1
ancref=$(git merge-base 9fea82fd7b67df4dccd0334701b05a7e021d1944 6310ed8782e4ecb8683dccd61fbb3edc15a13ed9)
git cherry-pick -x $ancref..6310ed8782e4ecb8683dccd61fbb3edc15a13ed9

@leejanee leejanee mentioned this pull request Oct 20, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] implement apply-only-once option for #op.ApplyComponent in workflow
4 participants