New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: health scope controller support check trait-managing workload #2527
Feat: health scope controller support check trait-managing workload #2527
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2527 +/- ##
==========================================
+ Coverage 61.63% 62.19% +0.55%
==========================================
Files 182 182
Lines 17575 17658 +83
==========================================
+ Hits 10832 10982 +150
+ Misses 5549 5483 -66
+ Partials 1194 1193 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pkg/controller/core.oam.dev/v1alpha2/application/assemble/assemble.go
Outdated
Show resolved
Hide resolved
Fix: e2e-test lint Fix: all e2e-test Fix: modify port back middle commit middle pr Fix: e2e-rollout-test make reviewable defet to rollout apply gvk annotation fix e2e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after nit
Co-authored-by: Hongchao Deng <hongchaodeng1@gmail.com>
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.1
git worktree add -d .worktree/backport-2527-to-release-1.1 origin/release-1.1
cd .worktree/backport-2527-to-release-1.1
git checkout -b backport-2527-to-release-1.1
ancref=$(git merge-base 99f1743d255674299afdcf1cb859b1e75e1109ce 4ad99cdb3ecf3df901d25b25b80c03d54a219579)
git cherry-pick -x $ancref..4ad99cdb3ecf3df901d25b25b80c03d54a219579 |
Description of your changes
Feat: health scope controller support check trait-managing workload
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer