Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: health scope controller support check trait-managing workload #2527

Merged
merged 3 commits into from Oct 26, 2021
Merged

Feat: health scope controller support check trait-managing workload #2527

merged 3 commits into from Oct 26, 2021

Conversation

wangyikewxgm
Copy link
Collaborator

Description of your changes

Feat: health scope controller support check trait-managing workload

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #2527 (4ad99cd) into master (99f1743) will increase coverage by 0.55%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2527      +/-   ##
==========================================
+ Coverage   61.63%   62.19%   +0.55%     
==========================================
  Files         182      182              
  Lines       17575    17658      +83     
==========================================
+ Hits        10832    10982     +150     
+ Misses       5549     5483      -66     
+ Partials     1194     1193       -1     
Flag Coverage Δ
apiserver-unittests 11.32% <ø> (ø)
core-unittests 55.48% <26.19%> (-0.07%) ⬇️
e2e-multicluster-test 24.07% <47.61%> (+2.88%) ⬆️
e2e-rollout-tests 31.44% <47.61%> (+0.06%) ⬆️
e2etests 37.16% <30.95%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...troller/core.oam.dev/v1alpha2/application/apply.go 78.46% <ø> (+0.13%) ⬆️
...ev/v1alpha2/core/scopes/healthscope/healthscope.go 66.79% <0.00%> (+1.88%) ⬆️
.../core/scopes/healthscope/healthscope_controller.go 83.47% <76.19%> (+7.11%) ⬆️
...dev/v1alpha2/application/application_controller.go 77.47% <100.00%> (+7.65%) ⬆️
....oam.dev/v1alpha2/application/assemble/assemble.go 77.30% <100.00%> (+1.73%) ⬆️
...ard.oam.dev/v1alpha1/rollout/rollout_controller.go 80.17% <100.00%> (+1.66%) ⬆️
pkg/workflow/providers/kube/handle.go 62.10% <0.00%> (-6.53%) ⬇️
...m.dev/v1alpha1/envbinding/envbinding_controller.go 72.89% <0.00%> (-2.41%) ⬇️
pkg/controller/utils/capability.go 79.85% <0.00%> (-1.47%) ⬇️
apis/core.oam.dev/common/types.go 14.28% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99f1743...4ad99cd. Read the comment docs.

Fix: e2e-test

lint

Fix: all e2e-test

Fix: modify port back

middle commit

middle pr

Fix: e2e-rollout-test

make reviewable

defet to rollout apply gvk annotation

fix e2e
Copy link
Collaborator

@zzxwill zzxwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@hongchaodeng hongchaodeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nit

Co-authored-by: Hongchao Deng <hongchaodeng1@gmail.com>
@wonderflow wonderflow merged commit f48da21 into kubevela:master Oct 26, 2021
@github-actions
Copy link

Backport failed for release-1.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.1
git worktree add -d .worktree/backport-2527-to-release-1.1 origin/release-1.1
cd .worktree/backport-2527-to-release-1.1
git checkout -b backport-2527-to-release-1.1
ancref=$(git merge-base 99f1743d255674299afdcf1cb859b1e75e1109ce 4ad99cdb3ecf3df901d25b25b80c03d54a219579)
git cherry-pick -x $ancref..4ad99cdb3ecf3df901d25b25b80c03d54a219579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants