New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add nocalhost dev config trait definition #2545
Feat: add nocalhost dev config trait definition #2545
Conversation
/cc @FogDong |
Codecov Report
@@ Coverage Diff @@
## master #2545 +/- ##
==========================================
- Coverage 61.77% 61.53% -0.25%
==========================================
Files 182 182
Lines 17632 17632
==========================================
- Hits 10892 10849 -43
- Misses 5540 5570 +30
- Partials 1200 1213 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Can you add an example in docs/examples/nocalhost
?
add nocalhost dev config trait example in `docs/examples/nocalhost` Signed-off-by: yuyicai <yuyicai@hotmail.com>
Hi! I have added the example in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks
/backport 1.1 |
Successfully created backport PR #2564 for |
Description of your changes
add nocalhost dev config trait definition
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer