Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add nocalhost dev config trait definition #2545

Conversation

yuyicai
Copy link
Contributor

@yuyicai yuyicai commented Oct 25, 2021

Description of your changes

add nocalhost dev config trait definition

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@ghost
Copy link

ghost commented Oct 25, 2021

CLA assistant check
All CLA requirements met.

@yuyicai
Copy link
Contributor Author

yuyicai commented Oct 25, 2021

/cc @FogDong

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #2545 (7011487) into master (e9ac4bb) will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2545      +/-   ##
==========================================
- Coverage   61.77%   61.53%   -0.25%     
==========================================
  Files         182      182              
  Lines       17632    17632              
==========================================
- Hits        10892    10849      -43     
- Misses       5540     5570      +30     
- Partials     1200     1213      +13     
Flag Coverage Δ
apiserver-unittests 11.32% <ø> (ø)
core-unittests 55.47% <ø> (-0.14%) ⬇️
e2e-multicluster-test 21.27% <ø> (-0.04%) ⬇️
e2e-rollout-tests 31.28% <ø> (-0.07%) ⬇️
e2etests 37.05% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/core.oam.dev/v1alpha2/application/dispatch/gc.go 70.49% <0.00%> (-8.20%) ⬇️
apis/core.oam.dev/condition/condition.go 42.85% <0.00%> (-7.80%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 65.26% <0.00%> (-5.27%) ⬇️
...m.dev/v1alpha1/envbinding/envbinding_controller.go 69.27% <0.00%> (-4.82%) ⬇️
...dev/v1alpha2/application/application_controller.go 69.81% <0.00%> (-4.06%) ⬇️
...es/policydefinition/policydefinition_controller.go 60.25% <0.00%> (-2.57%) ⬇️
...troller/core.oam.dev/v1alpha1/envbinding/engine.go 73.09% <0.00%> (-1.17%) ⬇️
....oam.dev/v1alpha2/application/dispatch/dispatch.go 76.16% <0.00%> (-1.17%) ⬇️
...troller/core.oam.dev/v1alpha2/application/apply.go 78.32% <0.00%> (-0.99%) ⬇️
.../core/scopes/healthscope/healthscope_controller.go 76.36% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ac4bb...7011487. Read the comment docs.

Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Can you add an example in docs/examples/nocalhost?

add nocalhost dev config trait example in `docs/examples/nocalhost`

Signed-off-by: yuyicai <yuyicai@hotmail.com>
@yuyicai
Copy link
Contributor Author

yuyicai commented Oct 26, 2021

Cool! Can you add an example in docs/examples/nocalhost?

Hi! I have added the example in docs/examples/nocalhost @FogDong

Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks

@wonderflow wonderflow merged commit 4dd18d1 into kubevela:master Oct 26, 2021
@FogDong
Copy link
Member

FogDong commented Oct 27, 2021

/backport 1.1

@github-actions
Copy link

Successfully created backport PR #2564 for release-1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants