Fix: allow external cloud resources to be kept when Application is deleted #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leted Provide an option for users whether to keep provisioned cloud resources when Terraform-typed Application is deleted. Fix kubevela#2697
zzxwill
force-pushed
the
override-region
branch
from
38b70c5
to
2ff4c72
Compare
Codecov Report
@@ Coverage Diff @@
## master #2698 +/- ##
==========================================
+ Coverage 58.60% 61.69% +3.09%
==========================================
Files 186 186
Lines 17759 17756 -3
==========================================
+ Hits 10407 10955 +548
+ Misses 6181 5608 -573
- Partials 1171 1193 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zzxwill
requested review from
hongchaodeng,
leejanee and
wonderflow
as code owners
wonderflow
reviewed
Nov 16, 2021
|
|
||
| // ProviderReference specifies the reference to Provider | ||
| ProviderReference *types.Reference `json:"providerRef,omitempty"` | ||
| v1beta1.BaseConfigurationSpec `json:",inline"` |
There was a problem hiding this comment.
do we keep the compatiblity here？
There was a problem hiding this comment.
Yes, the CRD didn't change and I have tested VPC with remote git repo. And I will port e2e tests from https://github.com/oam-dev/terraform-controller/blob/master/.github/workflows/e2e-test.yml to this repo once it got stable.
wonderflow
approved these changes
Nov 16, 2021
|
/backport 1.1 |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.1
git worktree add -d .worktree/backport-2698-to-release-1.1 origin/release-1.1
cd .worktree/backport-2698-to-release-1.1
git checkout -b backport-2698-to-release-1.1
ancref=$(git merge-base 3df47d74f1937afa78a6241b1e168de51dd35118 849214960c13f81e0c1bd05fbcc620c8d920d23a)
git cherry-pick -x $ancref..849214960c13f81e0c1bd05fbcc620c8d920d23a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an option for users whether to keep provisioned cloud resources when Terraform-typed Application is deleted.
Fix #2697
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer