Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: lookupByScript don't support import #2788

Merged
merged 2 commits into from Nov 24, 2021

Conversation

leejanee
Copy link
Member

@leejanee leejanee commented Nov 23, 2021

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #2788 (349a7bf) into master (3d2fcac) will increase coverage by 0.14%.
The diff coverage is 73.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2788      +/-   ##
==========================================
+ Coverage   59.72%   59.87%   +0.14%     
==========================================
  Files         223      223              
  Lines       22855    22895      +40     
==========================================
+ Hits        13650    13708      +58     
+ Misses       7534     7525       -9     
+ Partials     1671     1662       -9     
Flag Coverage Δ
apiserver-unittests 27.14% <61.90%> (+0.44%) ⬆️
core-unittests 54.71% <73.80%> (+0.02%) ⬆️
e2e-multicluster-test 23.38% <0.00%> (+0.06%) ⬆️
e2e-rollout-tests 30.96% <0.00%> (-0.04%) ⬇️
e2etests 36.39% <0.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cue/model/value/value.go 83.17% <73.80%> (-1.59%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 65.26% <0.00%> (-5.27%) ⬇️
...dev/v1alpha2/applicationconfiguration/component.go 58.26% <0.00%> (-0.79%) ⬇️
...tepdefinition/workflowstepdefinition_controller.go 69.14% <0.00%> (ø)
pkg/oam/util/helper.go 73.90% <0.00%> (+0.48%) ⬆️
pkg/multicluster/cluster_management.go 49.28% <0.00%> (+0.71%) ⬆️
...am.dev/v1alpha2/applicationconfiguration/render.go 88.21% <0.00%> (+0.81%) ⬆️
pkg/controller/utils/capability.go 80.51% <0.00%> (+1.27%) ⬆️
...ler/core.oam.dev/v1alpha2/application/generator.go 78.57% <0.00%> (+1.58%) ⬆️
...es/policydefinition/policydefinition_controller.go 62.82% <0.00%> (+2.56%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d2fcac...349a7bf. Read the comment docs.

@zzxwill zzxwill merged commit da251f1 into kubevela:master Nov 24, 2021
zzxwill added a commit to zzxwill/kubevela that referenced this pull request Nov 24, 2021
Fixed the probelm of renderring cue template for terraform provider
after kubevela#2788
wonderflow pushed a commit that referenced this pull request Nov 24, 2021
)

Fixed the probelm of renderring cue template for terraform provider
after #2788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants