New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: lookupByScript don't support import
#2788
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzxwill
approved these changes
Nov 23, 2021
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #2788 +/- ##
==========================================
+ Coverage 59.72% 59.87% +0.14%
==========================================
Files 223 223
Lines 22855 22895 +40
==========================================
+ Hits 13650 13708 +58
+ Misses 7534 7525 -9
+ Partials 1671 1662 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hongchaodeng
approved these changes
Nov 23, 2021
FogDong
approved these changes
Nov 23, 2021
leejanee
force-pushed
the
fix-loolup-byscript
branch
from
November 24, 2021 09:36
c710d48
to
349a7bf
Compare
zzxwill
added a commit
to zzxwill/kubevela
that referenced
this pull request
Nov 24, 2021
Fixed the probelm of renderring cue template for terraform provider after kubevela#2788
4 tasks
wonderflow
pushed a commit
that referenced
this pull request
Nov 24, 2021
) Fixed the probelm of renderring cue template for terraform provider after #2788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer