Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add workflow rollback cli #2795

Merged
merged 2 commits into from Nov 24, 2021
Merged

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Nov 24, 2021

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

/cc @barnettZQG @wonderflow

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #2795 (9525d9f) into master (8bcffb9) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2795      +/-   ##
==========================================
- Coverage   59.86%   59.77%   -0.09%     
==========================================
  Files         223      223              
  Lines       22735    22855     +120     
==========================================
+ Hits        13610    13662      +52     
- Misses       7473     7534      +61     
- Partials     1652     1659       +7     
Flag Coverage Δ
apiserver-unittests 26.99% <ø> (-0.09%) ⬇️
core-unittests 54.64% <ø> (+<0.01%) ⬆️
e2e-multicluster-test 23.51% <ø> (+0.03%) ⬆️
e2e-rollout-tests 31.05% <ø> (-0.07%) ⬇️
e2etests 36.31% <ø> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/core.oam.dev/v1alpha2/application/dispatch/gc.go 66.37% <0.00%> (-14.51%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 65.26% <0.00%> (-7.37%) ⬇️
...ponentdefinition/componentdefinition_controller.go 80.00% <0.00%> (-5.56%) ⬇️
pkg/appfile/parser.go 63.52% <0.00%> (-3.59%) ⬇️
pkg/apiserver/rest/usecase/workflow.go 60.22% <0.00%> (-2.36%) ⬇️
...troller/core.oam.dev/v1alpha2/application/apply.go 84.12% <0.00%> (-2.32%) ⬇️
pkg/apiserver/rest/usecase/envbinding.go 65.81% <0.00%> (-1.02%) ⬇️
pkg/addon/addon.go 35.96% <0.00%> (-0.88%) ⬇️
...am.dev/v1alpha2/applicationconfiguration/render.go 87.39% <0.00%> (-0.82%) ⬇️
pkg/appfile/appfile.go 75.41% <0.00%> (-0.65%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bcffb9...9525d9f. Read the comment docs.

@wonderflow wonderflow merged commit 6f90155 into kubevela:master Nov 24, 2021
whalecoiner pushed a commit to whalecoiner/kubevela that referenced this pull request Feb 7, 2022
* Feat: add workflow rollback cli

* fix ci

Signed-off-by: Chazza <github@whalecoiner.com>
@FogDong FogDong deleted the feat-rollbackcli branch June 30, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants