Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: backport Terraform releated PR #2829

Conversation

zzxwill
Copy link
Collaborator

@zzxwill zzxwill commented Nov 29, 2021

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #2829 (51b876a) into release-1.1 (e636d7c) will decrease coverage by 19.31%.
The diff coverage is 0.00%.

❗ Current head 51b876a differs from pull request most recent head 93b5a46. Consider uploading reports for the commit 93b5a46 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           release-1.1    #2829       +/-   ##
================================================
- Coverage        49.95%   30.64%   -19.32%     
================================================
  Files              223      165       -58     
  Lines            23654    16591     -7063     
================================================
- Hits             11817     5084     -6733     
- Misses           10547    10594       +47     
+ Partials          1290      913      -377     
Flag Coverage Δ
e2e-multicluster-test ?
e2e-rollout-tests 30.64% <0.00%> (+0.01%) ⬆️
e2etests ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/appfile/appfile.go 33.42% <0.00%> (-43.41%) ⬇️
pkg/utils/url.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/json.go 0.00% <0.00%> (-100.00%) ⬇️
apis/core.oam.dev/v1beta1/initializer_type.go 0.00% <0.00%> (-100.00%) ⬇️
...core.oam.dev/v1alpha2/applicationrollout/common.go 0.00% <0.00%> (-100.00%) ⬇️
...alpha2/applicationconfiguration/controllerhooks.go 0.00% <0.00%> (-100.00%) ⬇️
.../rollout/workloads/statefulset_scale_controller.go 0.00% <0.00%> (-92.09%) ⬇️
...e.oam.dev/v1alpha2/component/validating_handler.go 10.52% <0.00%> (-89.48%) ⬇️
...ollout/workloads/statefulset_rollout_controller.go 0.00% <0.00%> (-89.29%) ⬇️
...e.oam.dev/v1alpha2/applicationconfiguration/dag.go 0.00% <0.00%> (-88.47%) ⬇️
... and 173 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e636d7c...93b5a46. Read the comment docs.

@zzxwill zzxwill force-pushed the release-1.1-terraform-controller-0.2.10 branch from 621991d to 51b876a Compare November 30, 2021 06:57
- Fix: upgrade terraform controller to v0.2.10 kubevela#2827
- Fix: support naming a terraform provider kubevela#2794

Signed-off-by: zzxwill <zzxwill@gmail.com>
@zzxwill zzxwill force-pushed the release-1.1-terraform-controller-0.2.10 branch from 51b876a to 93b5a46 Compare November 30, 2021 09:47
@wonderflow wonderflow merged commit c4c0063 into kubevela:release-1.1 Nov 30, 2021
@zzxwill zzxwill deleted the release-1.1-terraform-controller-0.2.10 branch November 30, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants