Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: application conditions confusion. #2834

Merged
merged 2 commits into from Nov 30, 2021

Conversation

leejanee
Copy link
Member

@leejanee leejanee commented Nov 29, 2021

Description of your changes

Fixes #2834

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #2834 (b5bb1a7) into master (13b0767) will increase coverage by 20.29%.
The diff coverage is 71.42%.

❗ Current head b5bb1a7 differs from pull request most recent head aa781b5. Consider uploading reports for the commit aa781b5 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2834       +/-   ##
===========================================
+ Coverage   40.50%   60.79%   +20.29%     
===========================================
  Files         222      179       -43     
  Lines       22656    17941     -4715     
===========================================
+ Hits         9177    10908     +1731     
+ Misses      11914     5867     -6047     
+ Partials     1565     1166      -399     
Flag Coverage Δ
apiserver-unittests ?
core-unittests 54.29% <33.33%> (?)
e2e-multicluster-test 24.59% <60.71%> (+0.10%) ⬆️
e2e-rollout-tests 31.22% <60.71%> (-0.07%) ⬇️
e2etests 36.62% <57.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dev/v1alpha2/application/application_controller.go 76.95% <50.00%> (+8.35%) ⬆️
apis/core.oam.dev/common/types.go 50.00% <100.00%> (+25.00%) ⬆️
pkg/workflow/workflow.go 84.35% <100.00%> (+12.10%) ⬆️
pkg/apiserver/rest/utils/cache.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/apiserver/rest/utils/version.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/multicluster/cluster_management.go 0.00% <0.00%> (-48.58%) ⬇️
pkg/apiserver/rest/utils/params.go 0.00% <0.00%> (-33.34%) ⬇️
pkg/velaql/providers/query/collector.go 32.62% <0.00%> (-32.63%) ⬇️
pkg/utils/parse.go 0.00% <0.00%> (-26.79%) ⬇️
pkg/workflow/tasks/template/load.go 48.00% <0.00%> (-24.00%) ⬇️
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13b0767...aa781b5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants