Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add trait service-account #2878

Merged
merged 1 commit into from Dec 3, 2021
Merged

Conversation

yangsoon
Copy link
Collaborator

@yangsoon yangsoon commented Dec 3, 2021

Signed-off-by: yangsoon songyang.song@alibaba-inc.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #2878 (43c28e3) into master (589480a) will increase coverage by 2.85%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2878      +/-   ##
==========================================
+ Coverage   56.94%   59.79%   +2.85%     
==========================================
  Files         226      226              
  Lines       23472    23472              
==========================================
+ Hits        13365    14036     +671     
+ Misses       8448     7758     -690     
- Partials     1659     1678      +19     
Flag Coverage Δ
apiserver-unittests 27.52% <ø> (+0.05%) ⬆️
core-unittests 53.55% <ø> (-0.07%) ⬇️
e2e-multicluster-test 24.65% <ø> (+0.02%) ⬆️
e2e-rollout-tests 31.37% <ø> (-0.13%) ⬇️
e2etests 36.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/multicluster/gc.go 64.28% <0.00%> (-16.67%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 75.78% <0.00%> (-7.37%) ⬇️
pkg/apiserver/rest/webservice/oam_application.go 60.65% <0.00%> (-6.56%) ⬇️
pkg/apiserver/rest/utils/bcode/bcode.go 43.33% <0.00%> (-3.34%) ⬇️
pkg/addon/addon.go 24.60% <0.00%> (-2.10%) ⬇️
pkg/apiserver/rest/usecase/workflow.go 66.43% <0.00%> (+0.70%) ⬆️
pkg/multicluster/cluster_management.go 49.28% <0.00%> (+0.71%) ⬆️
...dev/v1alpha2/applicationconfiguration/component.go 59.05% <0.00%> (+0.78%) ⬆️
pkg/cue/definition/template.go 64.52% <0.00%> (+0.85%) ⬆️
apis/standard.oam.dev/v1alpha1/rollout_state.go 72.53% <0.00%> (+1.03%) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 589480a...43c28e3. Read the comment docs.

@barnettZQG barnettZQG merged commit a528431 into kubevela:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants