Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: deprecate CRD discovery for CUE import in Definition to prevent memory leak and OOM crash #2925

Merged
merged 4 commits into from Dec 16, 2021

Conversation

leejanee
Copy link
Member

Signed-off-by: Jian.Li lj176172@alibaba-inc.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Disable package discover from kubernetes open api.
Alternative solution: issues 2924

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #2925 (a792aa0) into master (3b1f097) will increase coverage by 3.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2925      +/-   ##
==========================================
+ Coverage   56.49%   60.11%   +3.61%     
==========================================
  Files         239      239              
  Lines       24452    24447       -5     
==========================================
+ Hits        13814    14696     +882     
+ Misses       8925     8002     -923     
- Partials     1713     1749      +36     
Flag Coverage Δ
apiserver-unittests 26.42% <100.00%> (-0.94%) ⬇️
core-unittests 47.39% <0.00%> (+0.01%) ⬆️
e2e-multicluster-test 24.58% <100.00%> (-0.56%) ⬇️
e2e-rollout-tests 28.64% <100.00%> (-0.63%) ⬇️
e2etests 37.59% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/utils/utils.go 37.62% <ø> (+7.23%) ⬆️
pkg/cue/packages/package.go 76.41% <100.00%> (-5.41%) ⬇️
pkg/velaql/providers/query/collector.go 70.86% <0.00%> (-1.33%) ⬇️
pkg/apiserver/rest/usecase/addon.go 31.80% <0.00%> (-0.77%) ⬇️
pkg/addon/addon.go 45.16% <0.00%> (-0.24%) ⬇️
...dev/v1alpha2/applicationconfiguration/component.go 59.05% <0.00%> (+0.78%) ⬆️
...troller/core.oam.dev/v1alpha2/application/apply.go 66.07% <0.00%> (+1.19%) ⬆️
...plicationconfiguration/applicationconfiguration.go 88.58% <0.00%> (+1.20%) ⬆️
...core.oam.dev/v1alpha2/applicationrollout/helper.go 78.04% <0.00%> (+1.21%) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b1f097...a792aa0. Read the comment docs.

@wonderflow wonderflow changed the title Fix: incorrect crd cause that controller takes up too much memory Fix: deprecate crd discovery for CUE import in Definition to prevent memory leak and OOM crash Dec 15, 2021
@wonderflow wonderflow changed the title Fix: deprecate crd discovery for CUE import in Definition to prevent memory leak and OOM crash Fix: deprecate CRD discovery for CUE import in Definition to prevent memory leak and OOM crash Dec 15, 2021
@leejanee leejanee force-pushed the fix-package-discover branch 2 times, most recently from ac33a89 to 55ed6a3 Compare December 15, 2021 03:54
Signed-off-by: Jian.Li <lj176172@alibaba-inc.com>
Signed-off-by: Jian.Li <lj176172@alibaba-inc.com>
Signed-off-by: Jian.Li <lj176172@alibaba-inc.com>
Signed-off-by: Jian.Li <lj176172@alibaba-inc.com>
@leejanee leejanee merged commit 133a89b into kubevela:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants