New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: deprecate CRD discovery for CUE import in Definition to prevent memory leak and OOM crash #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2925 +/- ##
==========================================
+ Coverage 56.49% 60.11% +3.61%
==========================================
Files 239 239
Lines 24452 24447 -5
==========================================
+ Hits 13814 14696 +882
+ Misses 8925 8002 -923
- Partials 1713 1749 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
leejanee
force-pushed
the
fix-package-discover
branch
from
December 14, 2021 12:49
afc0eb1
to
4927619
Compare
wonderflow
changed the title
Fix: incorrect crd cause that controller takes up too much memory
Fix: deprecate crd discovery for CUE import in Definition to prevent memory leak and OOM crash
Dec 15, 2021
wonderflow
changed the title
Fix: deprecate crd discovery for CUE import in Definition to prevent memory leak and OOM crash
Fix: deprecate CRD discovery for CUE import in Definition to prevent memory leak and OOM crash
Dec 15, 2021
leejanee
force-pushed
the
fix-package-discover
branch
2 times, most recently
from
December 15, 2021 03:54
ac33a89
to
55ed6a3
Compare
leejanee
force-pushed
the
fix-package-discover
branch
from
December 15, 2021 09:09
ae86eaf
to
dabf3e5
Compare
wonderflow
approved these changes
Dec 15, 2021
FogDong
approved these changes
Dec 15, 2021
zzxwill
approved these changes
Dec 15, 2021
leejanee
force-pushed
the
fix-package-discover
branch
from
December 15, 2021 11:17
dabf3e5
to
afcde46
Compare
yangsoon
approved these changes
Dec 15, 2021
Signed-off-by: Jian.Li <lj176172@alibaba-inc.com>
Signed-off-by: Jian.Li <lj176172@alibaba-inc.com>
Signed-off-by: Jian.Li <lj176172@alibaba-inc.com>
leejanee
force-pushed
the
fix-package-discover
branch
from
December 16, 2021 09:08
afcde46
to
a792aa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jian.Li lj176172@alibaba-inc.com
Description of your changes
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer
Disable package discover from kubernetes open api.
Alternative solution: issues 2924