Feat: add default user in dex #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
FogDong
force-pushed
the
feat-dex-init-user
branch
from
ece1224
to
b79f4ff
Compare
Codecov Report
@@ Coverage Diff @@
## master #3753 +/- ##
===========================================
+ Coverage 27.50% 63.84% +36.34%
===========================================
Files 244 310 +66
Lines 19665 29343 +9678
===========================================
+ Hits 5408 18735 +13327
+ Misses 13290 8184 -5106
- Partials 967 2424 +1457
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
barnettZQG
reviewed
Apr 26, 2022
| @@ -105,29 +93,6 @@ func (u *userUsecaseImpl) Init(ctx context.Context) error { | |||
| }); err != nil { | |||
| return err | |||
| } | |||
| // print default password of admin user in log | |||
| log.Logger.Infof("initialized admin username and password: admin / %s\n", pwd) | |||
barnettZQG
approved these changes
Apr 26, 2022
wonderflow
reviewed
Apr 26, 2022
| @@ -105,29 +93,6 @@ func (u *userUsecaseImpl) Init(ctx context.Context) error { | |||
| }); err != nil { | |||
| return err | |||
| } | |||
| // print default password of admin user in log | |||
| log.Logger.Infof("initialized admin username and password: admin / %s\n", pwd) | |||
There was a problem hiding this comment.
yes, please keep it as users will read the old doc for the password.
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
FogDong
force-pushed
the
feat-dex-init-user
branch
from
8854b28
to
c68c5d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com
Description of your changes
add default user in dex
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer
/cc @barnettZQG