Fix: Add application name to the generated workload entities #3786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds the application name to the generated workloads metadata labels (e.g., deployments, jobs, etc) that are created using the standard component types:
webservice
,worker
,task
, andcron-task
.The motivation behind this change is to maintain the old behavior of the previous kubernetes runtime where generated entities such as deployments or their resulting pods carried the labels of the parent application and component. That enabled using label selectors to get all pods of an application:
The ability of retrieving pods by application name and/or component is quite convenient for both final users and intermediate tools that rely on that capability.
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
To test the changes, deploy the updated component definitions, and deploy example applications. For example:
Webservice application
Next create the application and check that the associated pods can be retrieved by component (as before) and by application name.
This tests were also executed for the other types of entities.
Special notes for your reviewer