Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support multi keys in patchKey #3826

Merged
merged 1 commit into from
May 8, 2022
Merged

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented May 7, 2022

Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com

Description of your changes

support multi keys in patchKey

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

/cc @leejanee

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@FogDong FogDong requested a review from leejanee as a code owner May 7, 2022 10:29
@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #3826 (bbbeeff) into master (94a82ce) will increase coverage by 0.11%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master    #3826      +/-   ##
==========================================
+ Coverage   64.03%   64.14%   +0.11%     
==========================================
  Files         312      312              
  Lines       29547    29567      +20     
==========================================
+ Hits        18920    18966      +46     
+ Misses       8180     8161      -19     
+ Partials     2447     2440       -7     
Flag Coverage Δ
apiserver-unittests 35.34% <0.00%> (+<0.01%) ⬆️
core-unittests 56.59% <86.66%> (+0.40%) ⬆️
e2e-multicluster-test 26.65% <0.00%> (-0.08%) ⬇️
e2e-rollout-tests 23.64% <0.00%> (+0.02%) ⬆️
e2etests 31.38% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cue/model/sets/operation.go 75.28% <86.66%> (+0.88%) ⬆️
...ller/core.oam.dev/v1alpha2/application/revision.go 73.97% <0.00%> (+0.09%) ⬆️
pkg/apiserver/rest/usecase/authentication.go 50.72% <0.00%> (+1.08%) ⬆️
pkg/appfile/parser.go 59.94% <0.00%> (+1.43%) ⬆️
pkg/workflow/recorder/recorder.go 87.09% <0.00%> (+1.61%) ⬆️
...dev/v1alpha2/application/application_controller.go 86.06% <0.00%> (+2.42%) ⬆️
pkg/apiserver/sync/cr2ux.go 61.53% <0.00%> (+5.12%) ⬆️
...aits/traitdefinition/traitdefinition_controller.go 77.89% <0.00%> (+5.26%) ⬆️
...es/policydefinition/policydefinition_controller.go 76.84% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a82ce...bbbeeff. Read the comment docs.

Copy link
Member

@leejanee leejanee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants