-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: resolve locally installed addons not being displayed #3827
Conversation
Addressed an issue where locally installed addons may not be displayed if one with the same name is in the registry Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #3827 +/- ##
==========================================
+ Coverage 62.66% 64.06% +1.39%
==========================================
Files 312 312
Lines 29561 29692 +131
==========================================
+ Hits 18524 19021 +497
+ Misses 8572 8211 -361
+ Partials 2465 2460 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job, please add some test cases
when an addon with the same as registry one is locally installed Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Thank you for you suggestions. Relevant tests have been added. |
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
i.e. local and registry Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Successfully created backport PR #3842 for |
Signed-off-by: Charlie Chiang charlie_c_0129@outlook.com
Description of your changes
Addressed an issue where locally installed addons being displayed as the registry one if there is an addon with the same name is in the registry.
Before
Notice the
dex
addon, which is installed from local sources, but displayed as the one in the registry.After
It is now displayed properly as locally installed (the one in KubeVela registry is not affected).
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Changes that need to apply to existing unit tests have been added.
Special notes for your reviewer