Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Refactors shell to have double quotes format #3830

Merged
merged 5 commits into from
May 9, 2022

Conversation

afzal442
Copy link
Contributor

@afzal442 afzal442 commented May 8, 2022

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: afzal442 <afzal442@gmail.com>
Signed-off-by: afzal442 <afzal442@gmail.com>
Signed-off-by: afzal442 <afzal442@gmail.com>
Signed-off-by: afzal442 <afzal442@gmail.com>
Signed-off-by: afzal442 <afzal442@gmail.com>
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for contributing, I'm curious what's the difference between the refactors.

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #3830 (62d33bb) into master (88fb854) will increase coverage by 1.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3830      +/-   ##
==========================================
+ Coverage   62.67%   63.96%   +1.28%     
==========================================
  Files         312      312              
  Lines       29645    29651       +6     
==========================================
+ Hits        18580    18966     +386     
+ Misses       8591     8224     -367     
+ Partials     2474     2461      -13     
Flag Coverage Δ
apiserver-unittests 35.15% <ø> (-0.03%) ⬇️
core-unittests 56.47% <ø> (-0.03%) ⬇️
e2e-multicluster-test 26.60% <ø> (+<0.01%) ⬆️
e2e-rollout-tests 23.58% <ø> (-0.05%) ⬇️
e2etests 31.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/sync/convert/convert.go 49.36% <0.00%> (-11.40%) ⬇️
...tepdefinition/workflowstepdefinition_controller.go 58.51% <0.00%> (-10.64%) ⬇️
pkg/apiserver/sync/cr2ux.go 56.41% <0.00%> (-5.13%) ⬇️
pkg/resourcetracker/app.go 88.88% <0.00%> (+1.01%) ⬆️
pkg/cue/model/sets/utils.go 80.85% <0.00%> (+1.06%) ⬆️
...troller/core.oam.dev/v1alpha2/application/apply.go 89.75% <0.00%> (+1.20%) ⬆️
pkg/workflow/recorder/recorder.go 87.09% <0.00%> (+1.61%) ⬆️
pkg/appfile/parser.go 59.94% <0.00%> (+1.72%) ⬆️
...dev/v1alpha2/application/application_controller.go 83.63% <0.00%> (+2.42%) ⬆️
...ller/core.oam.dev/v1alpha2/application/revision.go 73.03% <0.00%> (+2.62%) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88fb854...62d33bb. Read the comment docs.

@wonderflow wonderflow merged commit 8d99a35 into kubevela:master May 9, 2022
@afzal442 afzal442 deleted the refactor/shellcheck/bugbash branch May 9, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants